test: Add tests for GetArg methods / settings.json type coercion
Just add tests. No changes to application behavior. Tests will be
updated in the next commit changing & improving current behavior.
Include a Qt test for GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
behavior that happens if settings.json contains an integer value for any
of the configuration options which GUI settings can currently clash with
(-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
-server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
2022-03-07 13:29:46 -05:00
|
|
|
// Copyright (c) 2018 The Bitcoin Core developers
|
|
|
|
// Distributed under the MIT software license, see the accompanying
|
|
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
|
2022-03-24 18:33:14 +01:00
|
|
|
#include <init.h>
|
test: Add tests for GetArg methods / settings.json type coercion
Just add tests. No changes to application behavior. Tests will be
updated in the next commit changing & improving current behavior.
Include a Qt test for GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
behavior that happens if settings.json contains an integer value for any
of the configuration options which GUI settings can currently clash with
(-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
-server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
2022-03-07 13:29:46 -05:00
|
|
|
#include <qt/bitcoin.h>
|
|
|
|
#include <qt/test/optiontests.h>
|
|
|
|
#include <test/util/setup_common.h>
|
|
|
|
#include <util/system.h>
|
|
|
|
|
|
|
|
#include <QSettings>
|
|
|
|
#include <QTest>
|
|
|
|
|
|
|
|
#include <univalue.h>
|
|
|
|
|
|
|
|
//! Entry point for BitcoinApplication tests.
|
|
|
|
void OptionTests::optionTests()
|
|
|
|
{
|
qt: Avoid crash on startup if int specified in settings.json
Fix GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 that happens if
settings.json contains an integer value for any of the configuration
options which GUI settings can currently clash with (-dbcache, -par,
-spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy,
-proxy, -onion, -onion, -lang, and -prune).
Fix is a one-line change in ArgsManager::GetArg.
2022-03-07 13:29:46 -05:00
|
|
|
// Test regression https://github.com/bitcoin/bitcoin/issues/24457. Ensure
|
|
|
|
// that setting integer prune value doesn't cause an exception to be thrown
|
|
|
|
// in the OptionsModel constructor
|
test: Add tests for GetArg methods / settings.json type coercion
Just add tests. No changes to application behavior. Tests will be
updated in the next commit changing & improving current behavior.
Include a Qt test for GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
behavior that happens if settings.json contains an integer value for any
of the configuration options which GUI settings can currently clash with
(-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
-server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
2022-03-07 13:29:46 -05:00
|
|
|
gArgs.LockSettings([&](util::Settings& settings) {
|
|
|
|
settings.forced_settings.erase("prune");
|
|
|
|
settings.rw_settings["prune"] = 3814;
|
|
|
|
});
|
|
|
|
gArgs.WriteSettingsFile();
|
qt: Avoid crash on startup if int specified in settings.json
Fix GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 that happens if
settings.json contains an integer value for any of the configuration
options which GUI settings can currently clash with (-dbcache, -par,
-spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy,
-proxy, -onion, -onion, -lang, and -prune).
Fix is a one-line change in ArgsManager::GetArg.
2022-03-07 13:29:46 -05:00
|
|
|
OptionsModel{};
|
test: Add tests for GetArg methods / settings.json type coercion
Just add tests. No changes to application behavior. Tests will be
updated in the next commit changing & improving current behavior.
Include a Qt test for GUI startup crash reported by Rspigler in
https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
behavior that happens if settings.json contains an integer value for any
of the configuration options which GUI settings can currently clash with
(-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
-server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
2022-03-07 13:29:46 -05:00
|
|
|
gArgs.LockSettings([&](util::Settings& settings) {
|
|
|
|
settings.rw_settings.erase("prune");
|
|
|
|
});
|
|
|
|
gArgs.WriteSettingsFile();
|
|
|
|
}
|
2022-03-24 18:33:14 +01:00
|
|
|
|
|
|
|
void OptionTests::parametersInteraction()
|
|
|
|
{
|
|
|
|
// Test that the bug https://github.com/bitcoin-core/gui/issues/567 does not resurface.
|
|
|
|
// It was fixed via https://github.com/bitcoin-core/gui/pull/568.
|
|
|
|
// With fListen=false in ~/.config/Bitcoin/Bitcoin-Qt.conf and all else left as default,
|
|
|
|
// bitcoin-qt should set both -listen and -listenonion to false and start successfully.
|
|
|
|
gArgs.ClearPathCache();
|
|
|
|
|
|
|
|
gArgs.LockSettings([&](util::Settings& s) {
|
|
|
|
s.forced_settings.erase("listen");
|
|
|
|
s.forced_settings.erase("listenonion");
|
|
|
|
});
|
|
|
|
QVERIFY(!gArgs.IsArgSet("-listen"));
|
|
|
|
QVERIFY(!gArgs.IsArgSet("-listenonion"));
|
|
|
|
|
|
|
|
QSettings settings;
|
|
|
|
settings.setValue("fListen", false);
|
|
|
|
|
|
|
|
OptionsModel{};
|
|
|
|
|
|
|
|
const bool expected{false};
|
|
|
|
|
|
|
|
QVERIFY(gArgs.IsArgSet("-listen"));
|
|
|
|
QCOMPARE(gArgs.GetBoolArg("-listen", !expected), expected);
|
|
|
|
|
|
|
|
QVERIFY(gArgs.IsArgSet("-listenonion"));
|
|
|
|
QCOMPARE(gArgs.GetBoolArg("-listenonion", !expected), expected);
|
|
|
|
|
|
|
|
QVERIFY(AppInitParameterInteraction(gArgs));
|
|
|
|
|
|
|
|
// cleanup
|
|
|
|
settings.remove("fListen");
|
|
|
|
QVERIFY(!settings.contains("fListen"));
|
|
|
|
gArgs.ClearPathCache();
|
|
|
|
}
|