2022-04-13 14:11:59 +02:00
|
|
|
// Copyright (c) 2021 The Bitcoin Core developers
|
|
|
|
// Distributed under the MIT software license, see the accompanying
|
|
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
|
|
|
|
#include <core_io.h>
|
|
|
|
#include <hash.h>
|
|
|
|
#include <key.h>
|
|
|
|
#include <script/miniscript.h>
|
|
|
|
#include <script/script.h>
|
|
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
|
|
#include <test/fuzz/fuzz.h>
|
|
|
|
#include <test/fuzz/util.h>
|
|
|
|
#include <util/strencodings.h>
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
2022-02-21 12:48:23 +01:00
|
|
|
//! Some pre-computed data for more efficient string roundtrips and to simulate challenges.
|
2022-04-13 14:30:26 +02:00
|
|
|
struct TestData {
|
|
|
|
typedef CPubKey Key;
|
|
|
|
|
2022-02-21 12:48:23 +01:00
|
|
|
// Precomputed public keys, and a dummy signature for each of them.
|
2022-04-13 14:30:26 +02:00
|
|
|
std::vector<Key> dummy_keys;
|
|
|
|
std::map<Key, int> dummy_key_idx_map;
|
|
|
|
std::map<CKeyID, Key> dummy_keys_map;
|
2022-02-21 12:48:23 +01:00
|
|
|
std::map<Key, std::pair<std::vector<unsigned char>, bool>> dummy_sigs;
|
|
|
|
|
|
|
|
// Precomputed hashes of each kind.
|
|
|
|
std::vector<std::vector<unsigned char>> sha256;
|
|
|
|
std::vector<std::vector<unsigned char>> ripemd160;
|
|
|
|
std::vector<std::vector<unsigned char>> hash256;
|
|
|
|
std::vector<std::vector<unsigned char>> hash160;
|
|
|
|
std::map<std::vector<unsigned char>, std::vector<unsigned char>> sha256_preimages;
|
|
|
|
std::map<std::vector<unsigned char>, std::vector<unsigned char>> ripemd160_preimages;
|
|
|
|
std::map<std::vector<unsigned char>, std::vector<unsigned char>> hash256_preimages;
|
|
|
|
std::map<std::vector<unsigned char>, std::vector<unsigned char>> hash160_preimages;
|
2022-04-13 14:30:26 +02:00
|
|
|
|
|
|
|
//! Set the precomputed data.
|
|
|
|
void Init() {
|
|
|
|
unsigned char keydata[32] = {1};
|
|
|
|
for (size_t i = 0; i < 256; i++) {
|
|
|
|
keydata[31] = i;
|
|
|
|
CKey privkey;
|
|
|
|
privkey.Set(keydata, keydata + 32, true);
|
|
|
|
const Key pubkey = privkey.GetPubKey();
|
|
|
|
|
|
|
|
dummy_keys.push_back(pubkey);
|
|
|
|
dummy_key_idx_map.emplace(pubkey, i);
|
|
|
|
dummy_keys_map.insert({pubkey.GetID(), pubkey});
|
2022-02-21 12:48:23 +01:00
|
|
|
|
|
|
|
std::vector<unsigned char> sig;
|
|
|
|
privkey.Sign(uint256S(""), sig);
|
|
|
|
sig.push_back(1); // SIGHASH_ALL
|
|
|
|
dummy_sigs.insert({pubkey, {sig, i & 1}});
|
|
|
|
|
|
|
|
std::vector<unsigned char> hash;
|
|
|
|
hash.resize(32);
|
|
|
|
CSHA256().Write(keydata, 32).Finalize(hash.data());
|
|
|
|
sha256.push_back(hash);
|
|
|
|
if (i & 1) sha256_preimages[hash] = std::vector<unsigned char>(keydata, keydata + 32);
|
|
|
|
CHash256().Write(keydata).Finalize(hash);
|
|
|
|
hash256.push_back(hash);
|
|
|
|
if (i & 1) hash256_preimages[hash] = std::vector<unsigned char>(keydata, keydata + 32);
|
|
|
|
hash.resize(20);
|
|
|
|
CRIPEMD160().Write(keydata, 32).Finalize(hash.data());
|
|
|
|
assert(hash.size() == 20);
|
|
|
|
ripemd160.push_back(hash);
|
|
|
|
if (i & 1) ripemd160_preimages[hash] = std::vector<unsigned char>(keydata, keydata + 32);
|
|
|
|
CHash160().Write(keydata).Finalize(hash);
|
|
|
|
hash160.push_back(hash);
|
|
|
|
if (i & 1) hash160_preimages[hash] = std::vector<unsigned char>(keydata, keydata + 32);
|
2022-04-13 14:30:26 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} TEST_DATA;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Context to parse a Miniscript node to and from Script or text representation.
|
|
|
|
* Uses an integer (an index in the dummy keys array from the test data) as keys in order
|
|
|
|
* to focus on fuzzing the Miniscript nodes' test representation, not the key representation.
|
|
|
|
*/
|
|
|
|
struct ParserContext {
|
|
|
|
typedef CPubKey Key;
|
|
|
|
|
2022-04-14 19:01:26 +02:00
|
|
|
bool KeyCompare(const Key& a, const Key& b) const {
|
|
|
|
return a < b;
|
|
|
|
}
|
|
|
|
|
2022-04-13 14:30:26 +02:00
|
|
|
std::optional<std::string> ToString(const Key& key) const
|
|
|
|
{
|
|
|
|
auto it = TEST_DATA.dummy_key_idx_map.find(key);
|
|
|
|
if (it == TEST_DATA.dummy_key_idx_map.end()) return {};
|
|
|
|
uint8_t idx = it->second;
|
|
|
|
return HexStr(Span{&idx, 1});
|
|
|
|
}
|
|
|
|
|
2022-02-21 12:48:23 +01:00
|
|
|
std::vector<unsigned char> ToPKBytes(const Key& key) const
|
|
|
|
{
|
|
|
|
return {key.begin(), key.end()};
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<unsigned char> ToPKHBytes(const Key& key) const
|
|
|
|
{
|
|
|
|
const auto h = Hash160(key);
|
|
|
|
return {h.begin(), h.end()};
|
|
|
|
}
|
|
|
|
|
2022-04-13 14:30:26 +02:00
|
|
|
template<typename I>
|
|
|
|
std::optional<Key> FromString(I first, I last) const {
|
|
|
|
if (last - first != 2) return {};
|
|
|
|
auto idx = ParseHex(std::string(first, last));
|
|
|
|
if (idx.size() != 1) return {};
|
|
|
|
return TEST_DATA.dummy_keys[idx[0]];
|
|
|
|
}
|
|
|
|
|
|
|
|
template<typename I>
|
|
|
|
std::optional<Key> FromPKBytes(I first, I last) const {
|
2022-02-21 12:48:23 +01:00
|
|
|
CPubKey key;
|
2022-04-13 14:30:26 +02:00
|
|
|
key.Set(first, last);
|
|
|
|
if (!key.IsValid()) return {};
|
|
|
|
return key;
|
|
|
|
}
|
|
|
|
|
|
|
|
template<typename I>
|
|
|
|
std::optional<Key> FromPKHBytes(I first, I last) const {
|
|
|
|
assert(last - first == 20);
|
|
|
|
CKeyID keyid;
|
|
|
|
std::copy(first, last, keyid.begin());
|
|
|
|
const auto it = TEST_DATA.dummy_keys_map.find(keyid);
|
|
|
|
if (it == TEST_DATA.dummy_keys_map.end()) return {};
|
|
|
|
return it->second;
|
|
|
|
}
|
|
|
|
} PARSER_CTX;
|
|
|
|
|
2022-04-13 14:11:59 +02:00
|
|
|
//! Context that implements naive conversion from/to script only, for roundtrip testing.
|
|
|
|
struct ScriptParserContext {
|
|
|
|
//! For Script roundtrip we never need the key from a key hash.
|
|
|
|
struct Key {
|
|
|
|
bool is_hash;
|
|
|
|
std::vector<unsigned char> data;
|
|
|
|
};
|
|
|
|
|
2022-04-14 19:01:26 +02:00
|
|
|
bool KeyCompare(const Key& a, const Key& b) const {
|
|
|
|
return a.data < b.data;
|
|
|
|
}
|
|
|
|
|
2022-04-13 14:11:59 +02:00
|
|
|
const std::vector<unsigned char>& ToPKBytes(const Key& key) const
|
|
|
|
{
|
|
|
|
assert(!key.is_hash);
|
|
|
|
return key.data;
|
|
|
|
}
|
|
|
|
|
|
|
|
const std::vector<unsigned char> ToPKHBytes(const Key& key) const
|
|
|
|
{
|
|
|
|
if (key.is_hash) return key.data;
|
|
|
|
const auto h = Hash160(key.data);
|
|
|
|
return {h.begin(), h.end()};
|
|
|
|
}
|
|
|
|
|
|
|
|
template<typename I>
|
|
|
|
std::optional<Key> FromPKBytes(I first, I last) const
|
|
|
|
{
|
|
|
|
Key key;
|
|
|
|
key.data.assign(first, last);
|
|
|
|
key.is_hash = false;
|
|
|
|
return key;
|
|
|
|
}
|
|
|
|
|
|
|
|
template<typename I>
|
|
|
|
std::optional<Key> FromPKHBytes(I first, I last) const
|
|
|
|
{
|
|
|
|
Key key;
|
|
|
|
key.data.assign(first, last);
|
|
|
|
key.is_hash = true;
|
|
|
|
return key;
|
|
|
|
}
|
|
|
|
} SCRIPT_PARSER_CONTEXT;
|
|
|
|
|
2022-02-21 12:48:23 +01:00
|
|
|
//! Context to produce a satisfaction for a Miniscript node using the pre-computed data.
|
|
|
|
struct SatisfierContext: ParserContext {
|
|
|
|
// Timelock challenges satisfaction. Make the value (deterministically) vary to explore different
|
|
|
|
// paths.
|
|
|
|
bool CheckAfter(uint32_t value) const { return value % 2; }
|
|
|
|
bool CheckOlder(uint32_t value) const { return value % 2; }
|
|
|
|
|
|
|
|
// Signature challenges fulfilled with a dummy signature, if it was one of our dummy keys.
|
|
|
|
miniscript::Availability Sign(const CPubKey& key, std::vector<unsigned char>& sig) const {
|
|
|
|
const auto it = TEST_DATA.dummy_sigs.find(key);
|
|
|
|
if (it == TEST_DATA.dummy_sigs.end()) return miniscript::Availability::NO;
|
|
|
|
if (it->second.second) {
|
|
|
|
// Key is "available"
|
|
|
|
sig = it->second.first;
|
|
|
|
return miniscript::Availability::YES;
|
|
|
|
} else {
|
|
|
|
return miniscript::Availability::NO;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
//! Lookup generalization for all the hash satisfactions below
|
|
|
|
miniscript::Availability LookupHash(const std::vector<unsigned char>& hash, std::vector<unsigned char>& preimage,
|
|
|
|
const std::map<std::vector<unsigned char>, std::vector<unsigned char>>& map) const
|
|
|
|
{
|
|
|
|
const auto it = map.find(hash);
|
|
|
|
if (it == map.end()) return miniscript::Availability::NO;
|
|
|
|
preimage = it->second;
|
|
|
|
return miniscript::Availability::YES;
|
|
|
|
}
|
|
|
|
miniscript::Availability SatSHA256(const std::vector<unsigned char>& hash, std::vector<unsigned char>& preimage) const {
|
|
|
|
return LookupHash(hash, preimage, TEST_DATA.sha256_preimages);
|
|
|
|
}
|
|
|
|
miniscript::Availability SatRIPEMD160(const std::vector<unsigned char>& hash, std::vector<unsigned char>& preimage) const {
|
|
|
|
return LookupHash(hash, preimage, TEST_DATA.ripemd160_preimages);
|
|
|
|
}
|
|
|
|
miniscript::Availability SatHASH256(const std::vector<unsigned char>& hash, std::vector<unsigned char>& preimage) const {
|
|
|
|
return LookupHash(hash, preimage, TEST_DATA.hash256_preimages);
|
|
|
|
}
|
|
|
|
miniscript::Availability SatHASH160(const std::vector<unsigned char>& hash, std::vector<unsigned char>& preimage) const {
|
|
|
|
return LookupHash(hash, preimage, TEST_DATA.hash160_preimages);
|
|
|
|
}
|
|
|
|
} SATISFIER_CTX;
|
|
|
|
|
|
|
|
//! Context to check a satisfaction against the pre-computed data.
|
|
|
|
struct CheckerContext: BaseSignatureChecker {
|
|
|
|
TestData *test_data;
|
|
|
|
|
|
|
|
// Signature checker methods. Checks the right dummy signature is used.
|
|
|
|
bool CheckECDSASignature(const std::vector<unsigned char>& sig, const std::vector<unsigned char>& vchPubKey,
|
|
|
|
const CScript& scriptCode, SigVersion sigversion) const override
|
|
|
|
{
|
|
|
|
const CPubKey key{vchPubKey};
|
|
|
|
const auto it = TEST_DATA.dummy_sigs.find(key);
|
|
|
|
if (it == TEST_DATA.dummy_sigs.end()) return false;
|
|
|
|
return it->second.first == sig;
|
|
|
|
}
|
|
|
|
bool CheckLockTime(const CScriptNum& nLockTime) const override { return nLockTime.GetInt64() & 1; }
|
|
|
|
bool CheckSequence(const CScriptNum& nSequence) const override { return nSequence.GetInt64() & 1; }
|
|
|
|
} CHECKER_CTX;
|
|
|
|
|
|
|
|
//! Context to check for duplicates when instancing a Node.
|
|
|
|
struct KeyComparator {
|
|
|
|
bool KeyCompare(const CPubKey& a, const CPubKey& b) const {
|
|
|
|
return a < b;
|
|
|
|
}
|
|
|
|
} KEY_COMP;
|
|
|
|
|
|
|
|
// A dummy scriptsig to pass to VerifyScript (we always use Segwit v0).
|
|
|
|
const CScript DUMMY_SCRIPTSIG;
|
|
|
|
|
|
|
|
using Fragment = miniscript::Fragment;
|
|
|
|
using NodeRef = miniscript::NodeRef<CPubKey>;
|
|
|
|
using Node = miniscript::Node<CPubKey>;
|
|
|
|
using Type = miniscript::Type;
|
|
|
|
// https://github.com/llvm/llvm-project/issues/53444
|
|
|
|
// NOLINTNEXTLINE(misc-unused-using-decls)
|
|
|
|
using miniscript::operator"" _mst;
|
|
|
|
|
|
|
|
//! Construct a miniscript node as a shared_ptr.
|
|
|
|
template<typename... Args> NodeRef MakeNodeRef(Args&&... args) { return miniscript::MakeNodeRef<CPubKey>(KEY_COMP, std::forward<Args>(args)...); }
|
|
|
|
|
|
|
|
/** Information about a yet to be constructed Miniscript node. */
|
|
|
|
struct NodeInfo {
|
|
|
|
//! The type of this node
|
|
|
|
Fragment fragment;
|
|
|
|
//! Number of subs of this node
|
|
|
|
uint8_t n_subs;
|
|
|
|
//! The timelock value for older() and after(), the threshold value for multi() and thresh()
|
|
|
|
uint32_t k;
|
|
|
|
//! Keys for this node, if it has some
|
|
|
|
std::vector<CPubKey> keys;
|
|
|
|
//! The hash value for this node, if it has one
|
|
|
|
std::vector<unsigned char> hash;
|
|
|
|
|
|
|
|
NodeInfo(Fragment frag): fragment(frag), n_subs(0), k(0) {}
|
|
|
|
NodeInfo(Fragment frag, CPubKey key): fragment(frag), n_subs(0), k(0), keys({key}) {}
|
|
|
|
NodeInfo(Fragment frag, uint32_t _k): fragment(frag), n_subs(0), k(_k) {}
|
|
|
|
NodeInfo(Fragment frag, std::vector<unsigned char> h): fragment(frag), n_subs(0), k(0), hash(std::move(h)) {}
|
|
|
|
NodeInfo(uint8_t subs, Fragment frag): fragment(frag), n_subs(subs), k(0) {}
|
|
|
|
NodeInfo(uint8_t subs, Fragment frag, uint32_t _k): fragment(frag), n_subs(subs), k(_k) {}
|
|
|
|
NodeInfo(Fragment frag, uint32_t _k, std::vector<CPubKey> _keys): fragment(frag), n_subs(0), k(_k), keys(std::move(_keys)) {}
|
|
|
|
};
|
|
|
|
|
|
|
|
/** Pick an index in a collection from a single byte in the fuzzer's output. */
|
|
|
|
template<typename T, typename A>
|
|
|
|
T ConsumeIndex(FuzzedDataProvider& provider, A& col) {
|
|
|
|
const uint8_t i = provider.ConsumeIntegral<uint8_t>();
|
|
|
|
return col[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
CPubKey ConsumePubKey(FuzzedDataProvider& provider) {
|
|
|
|
return ConsumeIndex<CPubKey>(provider, TEST_DATA.dummy_keys);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<unsigned char> ConsumeSha256(FuzzedDataProvider& provider) {
|
|
|
|
return ConsumeIndex<std::vector<unsigned char>>(provider, TEST_DATA.sha256);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<unsigned char> ConsumeHash256(FuzzedDataProvider& provider) {
|
|
|
|
return ConsumeIndex<std::vector<unsigned char>>(provider, TEST_DATA.hash256);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<unsigned char> ConsumeRipemd160(FuzzedDataProvider& provider) {
|
|
|
|
return ConsumeIndex<std::vector<unsigned char>>(provider, TEST_DATA.ripemd160);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<unsigned char> ConsumeHash160(FuzzedDataProvider& provider) {
|
|
|
|
return ConsumeIndex<std::vector<unsigned char>>(provider, TEST_DATA.hash160);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::optional<uint32_t> ConsumeTimeLock(FuzzedDataProvider& provider) {
|
|
|
|
const uint32_t k = provider.ConsumeIntegral<uint32_t>();
|
|
|
|
if (k == 0 || k >= 0x80000000) return {};
|
|
|
|
return k;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Consume a Miniscript node from the fuzzer's output.
|
|
|
|
*
|
|
|
|
* This version is intended to have a fixed, stable, encoding for Miniscript nodes:
|
|
|
|
* - The first byte sets the type of the fragment. 0, 1 and all non-leaf fragments but thresh() are a
|
|
|
|
* single byte.
|
|
|
|
* - For the other leaf fragments, the following bytes depend on their type.
|
|
|
|
* - For older() and after(), the next 4 bytes define the timelock value.
|
|
|
|
* - For pk_k(), pk_h(), and all hashes, the next byte defines the index of the value in the test data.
|
|
|
|
* - For multi(), the next 2 bytes define respectively the threshold and the number of keys. Then as many
|
|
|
|
* bytes as the number of keys define the index of each key in the test data.
|
|
|
|
* - For thresh(), the next byte defines the threshold value and the following one the number of subs.
|
|
|
|
*/
|
|
|
|
std::optional<NodeInfo> ConsumeNodeStable(FuzzedDataProvider& provider) {
|
|
|
|
switch (provider.ConsumeIntegral<uint8_t>()) {
|
|
|
|
case 0: return {{Fragment::JUST_0}};
|
|
|
|
case 1: return {{Fragment::JUST_1}};
|
|
|
|
case 2: return {{Fragment::PK_K, ConsumePubKey(provider)}};
|
|
|
|
case 3: return {{Fragment::PK_H, ConsumePubKey(provider)}};
|
|
|
|
case 4: {
|
|
|
|
const auto k = ConsumeTimeLock(provider);
|
|
|
|
if (!k) return {};
|
|
|
|
return {{Fragment::OLDER, *k}};
|
|
|
|
}
|
|
|
|
case 5: {
|
|
|
|
const auto k = ConsumeTimeLock(provider);
|
|
|
|
if (!k) return {};
|
|
|
|
return {{Fragment::AFTER, *k}};
|
|
|
|
}
|
|
|
|
case 6: return {{Fragment::SHA256, ConsumeSha256(provider)}};
|
|
|
|
case 7: return {{Fragment::HASH256, ConsumeHash256(provider)}};
|
|
|
|
case 8: return {{Fragment::RIPEMD160, ConsumeRipemd160(provider)}};
|
|
|
|
case 9: return {{Fragment::HASH160, ConsumeHash160(provider)}};
|
|
|
|
case 10: {
|
|
|
|
const auto k = provider.ConsumeIntegral<uint8_t>();
|
|
|
|
const auto n_keys = provider.ConsumeIntegral<uint8_t>();
|
|
|
|
if (n_keys > 20 || k == 0 || k > n_keys) return {};
|
|
|
|
std::vector<CPubKey> keys{n_keys};
|
|
|
|
for (auto& key: keys) key = ConsumePubKey(provider);
|
|
|
|
return {{Fragment::MULTI, k, std::move(keys)}};
|
|
|
|
}
|
|
|
|
case 11: return {{3, Fragment::ANDOR}};
|
|
|
|
case 12: return {{2, Fragment::AND_V}};
|
|
|
|
case 13: return {{2, Fragment::AND_B}};
|
|
|
|
case 15: return {{2, Fragment::OR_B}};
|
|
|
|
case 16: return {{2, Fragment::OR_C}};
|
|
|
|
case 17: return {{2, Fragment::OR_D}};
|
|
|
|
case 18: return {{2, Fragment::OR_I}};
|
|
|
|
case 19: {
|
|
|
|
auto k = provider.ConsumeIntegral<uint8_t>();
|
|
|
|
auto n_subs = provider.ConsumeIntegral<uint8_t>();
|
|
|
|
if (k == 0 || k > n_subs) return {};
|
|
|
|
return {{n_subs, Fragment::THRESH, k}};
|
|
|
|
}
|
|
|
|
case 20: return {{1, Fragment::WRAP_A}};
|
|
|
|
case 21: return {{1, Fragment::WRAP_S}};
|
|
|
|
case 22: return {{1, Fragment::WRAP_C}};
|
|
|
|
case 23: return {{1, Fragment::WRAP_D}};
|
|
|
|
case 24: return {{1, Fragment::WRAP_V}};
|
|
|
|
case 25: return {{1, Fragment::WRAP_J}};
|
|
|
|
case 26: return {{1, Fragment::WRAP_N}};
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return {};
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Generate a Miniscript node based on the fuzzer's input.
|
|
|
|
*/
|
|
|
|
template<typename F>
|
|
|
|
NodeRef GenNode(F ConsumeNode, Type root_type = ""_mst) {
|
|
|
|
/** A stack of miniscript Nodes being built up. */
|
|
|
|
std::vector<NodeRef> stack;
|
|
|
|
/** The queue of instructions. */
|
|
|
|
std::vector<std::optional<NodeInfo>> todo{{}};
|
|
|
|
|
|
|
|
while (!todo.empty()) {
|
|
|
|
// The expected type we have to construct.
|
|
|
|
auto type_needed = todo.back();
|
|
|
|
if (!todo.back()) {
|
|
|
|
// Fragment/children have not been decided yet. Decide them.
|
|
|
|
auto node_info = ConsumeNode();
|
|
|
|
if (!node_info) return {};
|
|
|
|
uint8_t n_subs = node_info->n_subs;
|
|
|
|
todo.back() = std::move(node_info);
|
|
|
|
for (uint8_t i = 0; i < n_subs; i++) todo.push_back({});
|
|
|
|
} else {
|
|
|
|
// The back of todo has fragment and number of children decided, and
|
|
|
|
// those children have been constructed at the back of stack. Pop
|
|
|
|
// that entry off todo, and use it to construct a new NodeRef on
|
|
|
|
// stack.
|
|
|
|
const NodeInfo& info = *todo.back();
|
|
|
|
// Gather children from the back of stack.
|
|
|
|
std::vector<NodeRef> sub;
|
|
|
|
sub.reserve(info.n_subs);
|
|
|
|
for (size_t i = 0; i < info.n_subs; ++i) {
|
|
|
|
sub.push_back(std::move(*(stack.end() - info.n_subs + i)));
|
|
|
|
}
|
|
|
|
stack.erase(stack.end() - info.n_subs, stack.end());
|
|
|
|
// Construct new NodeRef.
|
|
|
|
NodeRef node;
|
|
|
|
if (info.keys.empty()) {
|
|
|
|
node = MakeNodeRef(info.fragment, std::move(sub), std::move(info.hash), info.k);
|
|
|
|
} else {
|
|
|
|
assert(sub.empty());
|
|
|
|
assert(info.hash.empty());
|
|
|
|
node = MakeNodeRef(info.fragment, std::move(info.keys), info.k);
|
|
|
|
}
|
|
|
|
// Verify acceptability.
|
|
|
|
if (!node || !node->IsValid()) return {};
|
|
|
|
// Move it to the stack.
|
|
|
|
stack.push_back(std::move(node));
|
|
|
|
todo.pop_back();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
assert(stack.size() == 1);
|
|
|
|
return std::move(stack[0]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/** Perform various applicable tests on a miniscript Node. */
|
|
|
|
void TestNode(const NodeRef& node, FuzzedDataProvider& provider)
|
|
|
|
{
|
|
|
|
if (!node) return;
|
|
|
|
|
|
|
|
// Check that it roundtrips to text representation
|
|
|
|
std::optional<std::string> str{node->ToString(PARSER_CTX)};
|
|
|
|
assert(str);
|
|
|
|
auto parsed = miniscript::FromString(*str, PARSER_CTX);
|
|
|
|
assert(parsed);
|
|
|
|
assert(*parsed == *node);
|
|
|
|
|
|
|
|
// Check consistency between script size estimation and real size.
|
|
|
|
auto script = node->ToScript(PARSER_CTX);
|
|
|
|
assert(node->ScriptSize() == script.size());
|
|
|
|
|
|
|
|
// Check consistency of "x" property with the script (type K is excluded, because it can end
|
|
|
|
// with a push of a key, which could match these opcodes).
|
|
|
|
if (!(node->GetType() << "K"_mst)) {
|
|
|
|
bool ends_in_verify = !(node->GetType() << "x"_mst);
|
|
|
|
assert(ends_in_verify == (script.back() == OP_CHECKSIG || script.back() == OP_CHECKMULTISIG || script.back() == OP_EQUAL));
|
|
|
|
}
|
|
|
|
|
|
|
|
// The rest of the checks only apply when testing a valid top-level script.
|
|
|
|
if (!node->IsValidTopLevel()) return;
|
|
|
|
|
|
|
|
// Check roundtrip to script
|
|
|
|
auto decoded = miniscript::FromScript(script, PARSER_CTX);
|
|
|
|
assert(decoded);
|
|
|
|
// Note we can't use *decoded == *node because the miniscript representation may differ, so we check that:
|
|
|
|
// - The script corresponding to that decoded form matchs exactly
|
|
|
|
// - The type matches exactly
|
|
|
|
assert(decoded->ToScript(PARSER_CTX) == script);
|
|
|
|
assert(decoded->GetType() == node->GetType());
|
|
|
|
|
|
|
|
if (provider.ConsumeBool() && node->GetOps() < MAX_OPS_PER_SCRIPT && node->ScriptSize() < MAX_STANDARD_P2WSH_SCRIPT_SIZE) {
|
|
|
|
// Optionally pad the script with OP_NOPs to max op the ops limit of the constructed script.
|
|
|
|
// This makes the script obviously not actually miniscript-compatible anymore, but the
|
|
|
|
// signatures constructed in this test don't commit to the script anyway, so the same
|
|
|
|
// miniscript satisfier will work. This increases the sensitivity of the test to the ops
|
|
|
|
// counting logic being too low, especially for simple scripts.
|
|
|
|
// Do this optionally because we're not solely interested in cases where the number of ops is
|
|
|
|
// maximal.
|
|
|
|
// Do not pad more than what would cause MAX_STANDARD_P2WSH_SCRIPT_SIZE to be reached, however,
|
|
|
|
// as that also invalidates scripts.
|
|
|
|
int add = std::min<int>(
|
|
|
|
MAX_OPS_PER_SCRIPT - node->GetOps(),
|
|
|
|
MAX_STANDARD_P2WSH_SCRIPT_SIZE - node->ScriptSize());
|
|
|
|
for (int i = 0; i < add; ++i) script.push_back(OP_NOP);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Run malleable satisfaction algorithm.
|
|
|
|
const CScript script_pubkey = CScript() << OP_0 << WitnessV0ScriptHash(script);
|
|
|
|
CScriptWitness witness_mal;
|
|
|
|
const bool mal_success = node->Satisfy(SATISFIER_CTX, witness_mal.stack, false) == miniscript::Availability::YES;
|
|
|
|
witness_mal.stack.push_back(std::vector<unsigned char>(script.begin(), script.end()));
|
|
|
|
|
|
|
|
// Run non-malleable satisfaction algorithm.
|
|
|
|
CScriptWitness witness_nonmal;
|
|
|
|
const bool nonmal_success = node->Satisfy(SATISFIER_CTX, witness_nonmal.stack, true) == miniscript::Availability::YES;
|
|
|
|
witness_nonmal.stack.push_back(std::vector<unsigned char>(script.begin(), script.end()));
|
|
|
|
|
|
|
|
if (nonmal_success) {
|
|
|
|
// Non-malleable satisfactions are bounded by GetStackSize().
|
|
|
|
assert(witness_nonmal.stack.size() <= node->GetStackSize());
|
|
|
|
// If a non-malleable satisfaction exists, the malleable one must also exist, and be identical to it.
|
|
|
|
assert(mal_success);
|
|
|
|
assert(witness_nonmal.stack == witness_mal.stack);
|
|
|
|
|
|
|
|
// Test non-malleable satisfaction.
|
|
|
|
ScriptError serror;
|
|
|
|
bool res = VerifyScript(DUMMY_SCRIPTSIG, script_pubkey, &witness_nonmal, STANDARD_SCRIPT_VERIFY_FLAGS, CHECKER_CTX, &serror);
|
|
|
|
// Non-malleable satisfactions are guaranteed to be valid if ValidSatisfactions().
|
|
|
|
if (node->ValidSatisfactions()) assert(res);
|
|
|
|
// More detailed: non-malleable satisfactions must be valid, or could fail with ops count error (if CheckOpsLimit failed),
|
|
|
|
// or with a stack size error (if CheckStackSize check failed).
|
|
|
|
assert(res ||
|
|
|
|
(!node->CheckOpsLimit() && serror == ScriptError::SCRIPT_ERR_OP_COUNT) ||
|
|
|
|
(!node->CheckStackSize() && serror == ScriptError::SCRIPT_ERR_STACK_SIZE));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (mal_success && (!nonmal_success || witness_mal.stack != witness_nonmal.stack)) {
|
|
|
|
// Test malleable satisfaction only if it's different from the non-malleable one.
|
|
|
|
ScriptError serror;
|
|
|
|
bool res = VerifyScript(DUMMY_SCRIPTSIG, script_pubkey, &witness_mal, STANDARD_SCRIPT_VERIFY_FLAGS, CHECKER_CTX, &serror);
|
|
|
|
// Malleable satisfactions are not guaranteed to be valid under any conditions, but they can only
|
|
|
|
// fail due to stack or ops limits.
|
|
|
|
assert(res || serror == ScriptError::SCRIPT_ERR_OP_COUNT || serror == ScriptError::SCRIPT_ERR_STACK_SIZE);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->IsSane()) {
|
|
|
|
// For sane nodes, the two algorithms behave identically.
|
|
|
|
assert(mal_success == nonmal_success);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that if a node is policy-satisfiable, the malleable satisfaction
|
|
|
|
// algorithm succeeds. Given that under IsSane() both satisfactions
|
|
|
|
// are identical, this implies that for such nodes, the non-malleable
|
|
|
|
// satisfaction will also match the expected policy.
|
|
|
|
bool satisfiable = node->IsSatisfiable([](const Node& node) -> bool {
|
|
|
|
switch (node.fragment) {
|
|
|
|
case Fragment::PK_K:
|
|
|
|
case Fragment::PK_H: {
|
|
|
|
auto it = TEST_DATA.dummy_sigs.find(node.keys[0]);
|
|
|
|
assert(it != TEST_DATA.dummy_sigs.end());
|
|
|
|
return it->second.second;
|
|
|
|
}
|
|
|
|
case Fragment::MULTI: {
|
|
|
|
size_t sats = 0;
|
|
|
|
for (const auto& key : node.keys) {
|
|
|
|
auto it = TEST_DATA.dummy_sigs.find(key);
|
|
|
|
assert(it != TEST_DATA.dummy_sigs.end());
|
|
|
|
sats += it->second.second;
|
|
|
|
}
|
|
|
|
return sats >= node.k;
|
|
|
|
}
|
|
|
|
case Fragment::OLDER:
|
|
|
|
case Fragment::AFTER:
|
|
|
|
return node.k & 1;
|
|
|
|
case Fragment::SHA256:
|
|
|
|
return TEST_DATA.sha256_preimages.count(node.data);
|
|
|
|
case Fragment::HASH256:
|
|
|
|
return TEST_DATA.hash256_preimages.count(node.data);
|
|
|
|
case Fragment::RIPEMD160:
|
|
|
|
return TEST_DATA.ripemd160_preimages.count(node.data);
|
|
|
|
case Fragment::HASH160:
|
|
|
|
return TEST_DATA.hash160_preimages.count(node.data);
|
|
|
|
default:
|
|
|
|
assert(false);
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
});
|
|
|
|
assert(mal_success == satisfiable);
|
|
|
|
}
|
|
|
|
|
2022-04-13 14:30:26 +02:00
|
|
|
} // namespace
|
|
|
|
|
|
|
|
void FuzzInit()
|
|
|
|
{
|
|
|
|
ECC_Start();
|
|
|
|
TEST_DATA.Init();
|
|
|
|
}
|
|
|
|
|
2022-02-21 12:48:23 +01:00
|
|
|
/** Fuzz target that runs TestNode on nodes generated using ConsumeNodeStable. */
|
|
|
|
FUZZ_TARGET_INIT(miniscript_stable, FuzzInit)
|
|
|
|
{
|
|
|
|
FuzzedDataProvider provider(buffer.data(), buffer.size());
|
|
|
|
TestNode(GenNode([&]() {
|
|
|
|
return ConsumeNodeStable(provider);
|
|
|
|
}), provider);
|
|
|
|
}
|
|
|
|
|
2022-04-13 14:30:26 +02:00
|
|
|
/* Fuzz tests that test parsing from a string, and roundtripping via string. */
|
|
|
|
FUZZ_TARGET_INIT(miniscript_string, FuzzInit)
|
|
|
|
{
|
|
|
|
FuzzedDataProvider provider(buffer.data(), buffer.size());
|
|
|
|
auto str = provider.ConsumeRemainingBytesAsString();
|
|
|
|
auto parsed = miniscript::FromString(str, PARSER_CTX);
|
|
|
|
if (!parsed) return;
|
|
|
|
|
|
|
|
const auto str2 = parsed->ToString(PARSER_CTX);
|
|
|
|
assert(str2);
|
|
|
|
auto parsed2 = miniscript::FromString(*str2, PARSER_CTX);
|
|
|
|
assert(parsed2);
|
|
|
|
assert(*parsed == *parsed2);
|
2022-04-13 14:11:59 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Fuzz tests that test parsing from a script, and roundtripping via script. */
|
|
|
|
FUZZ_TARGET(miniscript_script)
|
|
|
|
{
|
|
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
|
|
const std::optional<CScript> script = ConsumeDeserializable<CScript>(fuzzed_data_provider);
|
|
|
|
if (!script) return;
|
|
|
|
|
|
|
|
const auto ms = miniscript::FromScript(*script, SCRIPT_PARSER_CONTEXT);
|
|
|
|
if (!ms) return;
|
|
|
|
|
|
|
|
assert(ms->ToScript(SCRIPT_PARSER_CONTEXT) == *script);
|
|
|
|
}
|