foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/node/transaction.h

25 lines
895 B
C
Raw Normal View History

Remove unused TransactionError constants
2019-02-14 10:01:06 -05:00
// Copyright (c) 2017-2019 The Bitcoin Core developers
Factor BroadcastTransaction out of sendrawtransaction Factor out a new BroadcastTransaction function, performing the core work of the sendrawtransaction rpc, so that it can be used from the GUI code. Move it from src/rpc/ to src/node/.
2019-01-08 22:16:50 -08:00
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#ifndef BITCOIN_NODE_TRANSACTION_H
#define BITCOIN_NODE_TRANSACTION_H
Remove unused TransactionError constants
2019-02-14 10:01:06 -05:00
#include <attributes.h>
Factor BroadcastTransaction out of sendrawtransaction Factor out a new BroadcastTransaction function, performing the core work of the sendrawtransaction rpc, so that it can be used from the GUI code. Move it from src/rpc/ to src/node/.
2019-01-08 22:16:50 -08:00
#include <primitives/transaction.h>
#include <uint256.h>
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
#include <util/error.h>
Switch away from exceptions in refactored tx code After refactoring general-purpose PSBT and transaction code out of RPC code, for use in the GUI, it's no longer appropriate to throw exceptions. Instead we now return bools for success, and take an output parameter for an error object. We still use JSONRPCError() for the error objects, since only RPC callers actually care about the error codes.
2019-02-09 20:51:33 -08:00
/**
* Broadcast a transaction
*
* @param[in] tx the transaction to broadcast
* @param[out] &txid the txid of the transaction, if successfully broadcast
* @param[out] &err_string reference to std::string to fill with error string if available
Remove unused TransactionError constants
2019-02-14 10:01:06 -05:00
* @param[in] highfee Reject txs with fees higher than this (if 0, accept any fee)
* return error
Switch away from exceptions in refactored tx code After refactoring general-purpose PSBT and transaction code out of RPC code, for use in the GUI, it's no longer appropriate to throw exceptions. Instead we now return bools for success, and take an output parameter for an error object. We still use JSONRPCError() for the error objects, since only RPC callers actually care about the error codes.
2019-02-09 20:51:33 -08:00
*/
Remove unused TransactionError constants
2019-02-14 10:01:06 -05:00
NODISCARD TransactionError BroadcastTransaction(CTransactionRef tx, uint256& txid, std::string& err_string, const CAmount& highfee);
Factor BroadcastTransaction out of sendrawtransaction Factor out a new BroadcastTransaction function, performing the core work of the sendrawtransaction rpc, so that it can be used from the GUI code. Move it from src/rpc/ to src/node/.
2019-01-08 22:16:50 -08:00
#endif // BITCOIN_NODE_TRANSACTION_H
Copy permalink