foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-13 11:25:02 -05:00
Code Issues Activity

refactor: add thread safety lock assertion to WriteBlockIndexDB()

Browse source 
The new helper function, BlockManager::WriteBlockIndexDB(),
has a thread safety lock annotation in its declaration but is
missing the corresponding run-time lock assertion in its definition.

Per doc/developer-notes.md: "Combine annotations in function
declarations with run-time asserts in function definitions."
This commit is contained in:
Jon Atack 2022-01-07 13:10:18 +01:00
parent 4ada74206a
commit 1823766fc6
No known key found for this signature in database
GPG key ID: 796C4109063D4EAF
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/node/blockstorage.cpp
View file

@ -340,6 +340,7 @@ void BlockManager::Unload()
bool BlockManager::WriteBlockIndexDB() bool BlockManager::WriteBlockIndexDB()
{ {
AssertLockHeld(::cs_main);
std::vector<std::pair<int, const CBlockFileInfo*>> vFiles; std::vector<std::pair<int, const CBlockFileInfo*>> vFiles;
vFiles.reserve(m_dirty_fileinfo.size()); vFiles.reserve(m_dirty_fileinfo.size());
for (std::set<int>::iterator it = m_dirty_fileinfo.begin(); it != m_dirty_fileinfo.end();) { for (std::set<int>::iterator it = m_dirty_fileinfo.begin(); it != m_dirty_fileinfo.end();) {