foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-12 11:19:08 -05:00
Code Issues Activity

Avoid using mutable default parameter values

Browse source
This commit is contained in:
practicalswift 2019-08-25 21:49:49 +00:00
parent e00ecb3d7a
commit 25dd867150
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/functional/test_framework/messages.py
View file

@ -803,7 +803,9 @@ class HeaderAndShortIDs:
return [ key0, key1 ] return [ key0, key1 ]
# Version 2 compact blocks use wtxid in shortids (rather than txid) # Version 2 compact blocks use wtxid in shortids (rather than txid)
def initialize_from_block(self, block, nonce=0, prefill_list = [0], use_witness = False): def initialize_from_block(self, block, nonce=0, prefill_list=None, use_witness=False):
if prefill_list is None:
prefill_list = [0]
self.header = CBlockHeader(block) self.header = CBlockHeader(block)
self.nonce = nonce self.nonce = nonce
self.prefilled_txn = [ PrefilledTransaction(i, block.vtx[i]) for i in prefill_list ] self.prefilled_txn = [ PrefilledTransaction(i, block.vtx[i]) for i in prefill_list ]

4
test/functional/wallet_importmulti.py
View file

@ -44,8 +44,10 @@ class ImportMultiTest(BitcoinTestFramework):
def setup_network(self): def setup_network(self):
self.setup_nodes() self.setup_nodes()
def test_importmulti(self, req, success, error_code=None, error_message=None, warnings=[]): def test_importmulti(self, req, success, error_code=None, error_message=None, warnings=None):
"""Run importmulti and assert success""" """Run importmulti and assert success"""
if warnings is None:
warnings = []
result = self.nodes[1].importmulti([req]) result = self.nodes[1].importmulti([req])
observed_warnings = [] observed_warnings = []
if 'warnings' in result[0]: if 'warnings' in result[0]: