From 30a3230e86dfd49c771432be6219841df5066eb4 Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Wed, 15 Feb 2023 14:03:37 -0800 Subject: [PATCH] script: remove out-of-date snprintf TODO that was resolved in PR27036 "test: Remove last uses of snprintf and simplify" and while here, fix up 2 words in docs to make the spelling linter green again. --- src/blockencodings.h | 2 +- src/net.cpp | 2 +- test/lint/lint-locale-dependence.py | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/blockencodings.h b/src/blockencodings.h index 7207ff1ae2..afdfa426f1 100644 --- a/src/blockencodings.h +++ b/src/blockencodings.h @@ -135,7 +135,7 @@ protected: public: CBlockHeader header; - // Can be overriden for testing + // Can be overridden for testing using CheckBlockFn = std::function; CheckBlockFn m_check_block_mock{nullptr}; diff --git a/src/net.cpp b/src/net.cpp index 4f4e443976..884fe25543 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -1671,7 +1671,7 @@ void CConnman::ThreadOpenConnections(const std::vector connect) // Therefore, we do not add them to addrman in the first place. // In case previously unreachable networks become reachable // (e.g. in case of -onlynet changes by the user), fixed seeds will - // be loaded only for networks for which we have no addressses. + // be loaded only for networks for which we have no addresses. seed_addrs.erase(std::remove_if(seed_addrs.begin(), seed_addrs.end(), [&fixed_seed_networks](const CAddress& addr) { return fixed_seed_networks.count(addr.GetNetwork()) == 0; }), seed_addrs.end()); diff --git a/test/lint/lint-locale-dependence.py b/test/lint/lint-locale-dependence.py index b37ba05a93..faea643882 100755 --- a/test/lint/lint-locale-dependence.py +++ b/test/lint/lint-locale-dependence.py @@ -34,8 +34,6 @@ # # See https://doc.qt.io/qt-5/qcoreapplication.html#locale-settings and # https://stackoverflow.com/a/34878283 for more details. -# -# TODO: Reduce KNOWN_VIOLATIONS by replacing uses of locale dependent snprintf with strprintf. import re import sys