foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-15 11:36:00 -05:00
Code Issues Activity

Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes

Browse source 
that was added in 2015 by commit b8c06ef40 in PR 7003, as that potential issue
would now be caught by the test/lint/lint-format-strings.py script run by the CI
This commit is contained in:
Jon Atack 2022-06-07 15:39:29 +02:00
parent 45d8b1e94a
commit 433b525694
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
doc/developer-notes.md
View file

@ -831,11 +831,6 @@ int GetInt(Tabs tab)
Strings and formatting Strings and formatting
------------------------ ------------------------
- Be careful of `LogPrint` versus `LogPrintf`. `LogPrint` takes a `category` argument, `LogPrintf` does not.
- *Rationale*: Confusion of these can result in runtime exceptions due to
formatting mismatch, and it is easy to get wrong because of subtly similar naming.
- Use `std::string`, avoid C string manipulation functions. - Use `std::string`, avoid C string manipulation functions.
- *Rationale*: C++ string handling is marginally safer, less scope for - *Rationale*: C++ string handling is marginally safer, less scope for

1
test/lint/lint-format-strings.py
View file

@ -22,6 +22,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [
'LogConnectFailure,1', 'LogConnectFailure,1',
'LogPrint,1', 'LogPrint,1',
'LogPrintf,0', 'LogPrintf,0',
'LogPrintLevel,2',
'printf,0', 'printf,0',
'snprintf,2', 'snprintf,2',
'sprintf,1', 'sprintf,1',