foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

Merge bitcoin-core/gui#17: doc: Remove outdated comment in TransactionTablePriv

Browse source 
faebb60b8d doc: Remove outdated comment in TransactionTablePriv (MarcoFalke)

Pull request description:

  Locks are no longer taken upfront, so remove the outdated comment

ACKs for top commit:
  hebasto:
    ACK faebb60b8d, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: cd6df24d49d17e58049ac9b261c5e07c8e85ed1aacb547b13c0e55139339d7fcc3b1f766ea2e27d758ea77deadc01f7e28781be1515323c82b9012cee8fd488b
This commit is contained in:
MarcoFalke 2020-07-01 19:27:52 -04:00
commit 501203aa91
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/qt/transactiontablemodel.cpp
View file

@ -178,17 +178,12 @@ public:
TransactionRecord* index(interfaces::Wallet& wallet, const uint256& cur_block_hash, const int idx) TransactionRecord* index(interfaces::Wallet& wallet, const uint256& cur_block_hash, const int idx)
{ {
if(idx >= 0 && idx < cachedWallet.size()) if (idx >= 0 && idx < cachedWallet.size()) {
{
TransactionRecord *rec = &cachedWallet[idx]; TransactionRecord *rec = &cachedWallet[idx];
// Get required locks upfront. This avoids the GUI from getting
// stuck if the core is holding the locks for a longer time - for
// example, during a wallet rescan.
//
// If a status update is needed (blocks came in since last check), // If a status update is needed (blocks came in since last check),
// update the status of this transaction from the wallet. Otherwise, // try to update the status of this transaction from the wallet.
// simply re-use the cached status. // Otherwise, simply re-use the cached status.
interfaces::WalletTxStatus wtx; interfaces::WalletTxStatus wtx;
int numBlocks; int numBlocks;
int64_t block_time; int64_t block_time;