foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

refactor: Add thread safety annotation to BanMan::SweepBanned()

Browse source
This commit is contained in:
Hennadii Stepanov 2022-05-20 15:17:00 +02:00
parent 3919059deb
commit 52c0b3e859
No known key found for this signature in database
GPG key ID: 410108112E7EA81F
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/banman.cpp
View file

@ -179,10 +179,11 @@ void BanMan::GetBanned(banmap_t& banmap)
void BanMan::SweepBanned() void BanMan::SweepBanned()
{ {
AssertLockHeld(m_cs_banned);
int64_t now = GetTime(); int64_t now = GetTime();
bool notify_ui = false; bool notify_ui = false;
{ {
LOCK(m_cs_banned);
banmap_t::iterator it = m_banned.begin(); banmap_t::iterator it = m_banned.begin();
while (it != m_banned.end()) { while (it != m_banned.end()) {
CSubNet sub_net = (*it).first; CSubNet sub_net = (*it).first;

2
src/banman.h
View file

@ -85,7 +85,7 @@ private:
//!set the "dirty" flag for the banlist //!set the "dirty" flag for the banlist
void SetBannedSetDirty(bool dirty = true); void SetBannedSetDirty(bool dirty = true);
//!clean unused entries (if bantime has expired) //!clean unused entries (if bantime has expired)
void SweepBanned(); void SweepBanned() EXCLUSIVE_LOCKS_REQUIRED(m_cs_banned);
RecursiveMutex m_cs_banned; RecursiveMutex m_cs_banned;
banmap_t m_banned GUARDED_BY(m_cs_banned); banmap_t m_banned GUARDED_BY(m_cs_banned);