foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
Code Issues Activity

Randomize message processing peer order

Browse source
This commit is contained in:
Pieter Wuille 2021-06-02 13:54:41 -07:00
parent 2aab8a6dd0
commit 79c02c88b3
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/net.cpp
View file

@ -2173,6 +2173,7 @@ void CConnman::OpenNetworkConnection(const CAddress& addrConnect, bool fCountFai
void CConnman::ThreadMessageHandler() void CConnman::ThreadMessageHandler()
{ {
FastRandomContext rng;
while (!flagInterruptMsgProc) while (!flagInterruptMsgProc)
{ {
std::vector<CNode*> vNodesCopy; std::vector<CNode*> vNodesCopy;
@ -2186,6 +2187,11 @@ void CConnman::ThreadMessageHandler()
bool fMoreWork = false; bool fMoreWork = false;
// Randomize the order in which we process messages from/to our peers.
// This prevents attacks in which an attacker exploits having multiple
// consecutive connections in the vNodes list.
Shuffle(vNodesCopy.begin(), vNodesCopy.end(), rng);
for (CNode* pnode : vNodesCopy) for (CNode* pnode : vNodesCopy)
{ {
if (pnode->fDisconnect) if (pnode->fDisconnect)