foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#24566: build: Drop redundant checks for ranlib and strip tools

Browse source 
a0e2a3133a build: Drop redundant checks for ranlib and strip tools (Hennadii Stepanov)

Pull request description:

  These checks are handled by the `LT_INIT` macro.

  Inspired by bitcoin-core/secp256k1#1088.

  On master (f3e0ace8ec):
  ```
  $ ./configure --with-incompatible-bdb 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.'
  56:checking for strip... strip
  57:checking for ranlib... ranlib
  102:checking for ranlib... /usr/bin/ranlib
  103:checking for strip... /usr/bin/strip
  380:checking for strip... strip
  381:checking for ranlib... ranlib
  ```
  With this PR:
  ```
  $ ./configure --with-incompatible-bdb 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.'
  56:checking for strip... strip
  57:checking for ranlib... ranlib
  377:checking for strip... strip
  378:checking for ranlib... ranlib
  $ CONFIG_SITE=$PWD/depends/x86_64-apple-darwin/share/config.site ./configure 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.'
  8:checking for x86_64-apple-darwin-strip... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip
  61:checking for x86_64-apple-darwin-strip... (cached) /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip
  62:checking for x86_64-apple-darwin-ranlib... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib
  188:checking whether the linker accepts -Wl,-dead_strip... yes
  367:checking for x86_64-apple-darwin-strip... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip
  411:checking for x86_64-apple-darwin-strip... (cached) /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip
  412:checking for x86_64-apple-darwin-ranlib... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib
  ```

  #### Guix builds on `x86_64`:
  ```
  ...
  ```

ACKs for top commit:
  real-or-random:
    ACK a0e2a3133a
  fanquake:
    ACK a0e2a3133a

Tree-SHA512: 17e2f54a3fc0447d7a27592d4c803538b6e0dfe02eab9a234084d71f3d9244c2488d56301f6c57050592e0d760c2d48b2b7d365454754af2ce098e77c05d33cc
This commit is contained in:
fanquake 2022-05-05 15:25:21 +01:00
commit 7cc1860b12
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
configure.ac
View file

@ -108,8 +108,6 @@ LT_INIT([pic-only win32-dll])
dnl Check/return PATH for base programs.
AC_PATH_TOOL([AR], [ar])
AC_PATH_TOOL([RANLIB], [ranlib])
AC_PATH_TOOL([STRIP], [strip])
AC_PATH_TOOL([GCOV], [gcov])
AC_PATH_TOOL([LLVM_COV], [llvm-cov])
AC_PATH_PROG([LCOV], [lcov])