From 7e0db87d4fff996c086f6e86b62338c98ef30c55 Mon Sep 17 00:00:00 2001 From: kevkevinpal Date: Mon, 3 Feb 2025 09:07:52 -0500 Subject: [PATCH] test: added additional coverage to waitforblock and waitforblockheight rpc's --- test/functional/rpc_blockchain.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/functional/rpc_blockchain.py b/test/functional/rpc_blockchain.py index 224f802bb95..71fda3a1dbd 100755 --- a/test/functional/rpc_blockchain.py +++ b/test/functional/rpc_blockchain.py @@ -535,6 +535,7 @@ class BlockchainTest(BitcoinTestFramework): self.log.debug("waitforblock should return the same block after its timeout") assert_equal(node.waitforblock(blockhash=current_hash, timeout=1)['hash'], rollback_header['previousblockhash']) + assert_raises_rpc_error(-1, "Negative timeout", node.waitforblock, current_hash, -1) node.reconsiderblock(rollback_hash) # The chain has probably already been restored by the time reconsiderblock returns, @@ -589,6 +590,7 @@ class BlockchainTest(BitcoinTestFramework): assert_waitforheight(current_height - 1) assert_waitforheight(current_height) assert_waitforheight(current_height + 1) + assert_raises_rpc_error(-1, "Negative timeout", node.waitforblockheight, current_height, -1) def _test_getblock(self): node = self.nodes[0]