diff --git a/src/sync.cpp b/src/sync.cpp index ef46bbb22f..eace86d9dd 100644 --- a/src/sync.cpp +++ b/src/sync.cpp @@ -24,15 +24,10 @@ #include #include -#ifdef DEBUG_LOCKCONTENTION -#if !defined(HAVE_THREAD_LOCAL) -static_assert(false, "thread_local is not supported"); -#endif void LockContention(const char* pszName, const char* pszFile, int nLine) { LOG_TIME_MICROS_WITH_CATEGORY(strprintf("%s, %s:%d", pszName, pszFile, nLine), BCLog::LOCK); } -#endif /* DEBUG_LOCKCONTENTION */ #ifdef DEBUG_LOCKORDER // diff --git a/src/sync.h b/src/sync.h index f4f6ece41d..bf15c0b4eb 100644 --- a/src/sync.h +++ b/src/sync.h @@ -126,10 +126,8 @@ using RecursiveMutex = AnnotatedMixin; /** Wrapped mutex: supports waiting but not recursive locking */ typedef AnnotatedMixin Mutex; -#ifdef DEBUG_LOCKCONTENTION /** Prints a lock contention to the log */ void LockContention(const char* pszName, const char* pszFile, int nLine); -#endif /** Wrapper around std::unique_lock style lock for Mutex. */ template @@ -139,22 +137,18 @@ private: void Enter(const char* pszName, const char* pszFile, int nLine) { EnterCritical(pszName, pszFile, nLine, Base::mutex()); -#ifdef DEBUG_LOCKCONTENTION - if (!Base::try_lock()) { - LockContention(pszName, pszFile, nLine); // log the contention -#endif - Base::lock(); -#ifdef DEBUG_LOCKCONTENTION - } -#endif + if (Base::try_lock()) return; + LockContention(pszName, pszFile, nLine); // log the contention + Base::lock(); } bool TryEnter(const char* pszName, const char* pszFile, int nLine) { EnterCritical(pszName, pszFile, nLine, Base::mutex(), true); Base::try_lock(); - if (!Base::owns_lock()) + if (!Base::owns_lock()) { LeaveCritical(); + } return Base::owns_lock(); }