foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

[refactor] use reference in for loop through iters

Browse source
This commit is contained in:
glozow 2024-05-02 11:24:36 +01:00
parent 6119f76ef7
commit 7f6fb73c82
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/txorphanage.cpp
View file

@ -278,7 +278,7 @@ std::vector<CTransactionRef> TxOrphanage::GetChildrenFromSamePeer(const CTransac
// Convert to a vector of CTransactionRef // Convert to a vector of CTransactionRef
std::vector<CTransactionRef> children_found; std::vector<CTransactionRef> children_found;
children_found.reserve(iters.size()); children_found.reserve(iters.size());
for (const auto child_iter : iters) { for (const auto& child_iter : iters) {
children_found.emplace_back(child_iter->second.tx); children_found.emplace_back(child_iter->second.tx);
} }
return children_found; return children_found;
@ -310,7 +310,7 @@ std::vector<std::pair<CTransactionRef, NodeId>> TxOrphanage::GetChildrenFromDiff
// Convert iterators to pair<CTransactionRef, NodeId> // Convert iterators to pair<CTransactionRef, NodeId>
std::vector<std::pair<CTransactionRef, NodeId>> children_found; std::vector<std::pair<CTransactionRef, NodeId>> children_found;
children_found.reserve(iters.size()); children_found.reserve(iters.size());
for (const auto child_iter : iters) { for (const auto& child_iter : iters) {
children_found.emplace_back(child_iter->second.tx, child_iter->second.fromPeer); children_found.emplace_back(child_iter->second.tx, child_iter->second.fromPeer);
} }
return children_found; return children_found;