foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-12 11:19:08 -05:00
Code Issues Activity

rpc: call RecalculateBestHeader as part of reconsiderblock

Browse source 
Co-authored-by: Fabian Jahr <fjahr@protonmail.com>
This commit is contained in:
Martin Zumsande 2024-08-14 16:47:49 -04:00
parent a51e91783a
commit 9275e9689a
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/rpc/blockchain.cpp
View file

@ -1648,6 +1648,7 @@ void ReconsiderBlock(ChainstateManager& chainman, uint256 block_hash) {
} }
chainman.ActiveChainstate().ResetBlockFailureFlags(pblockindex); chainman.ActiveChainstate().ResetBlockFailureFlags(pblockindex);
chainman.RecalculateBestHeader();
} }
BlockValidationState state; BlockValidationState state;

2
test/functional/rpc_invalidateblock.py
View file

@ -83,6 +83,8 @@ class InvalidateTest(BitcoinTestFramework):
self.nodes[1].reconsiderblock(blocks[-4]) self.nodes[1].reconsiderblock(blocks[-4])
# Should be back at the tip by now # Should be back at the tip by now
assert_equal(self.nodes[1].getbestblockhash(), blocks[-1]) assert_equal(self.nodes[1].getbestblockhash(), blocks[-1])
# Should report consistent blockchain info
assert_equal(self.nodes[1].getblockchaininfo()["headers"], self.nodes[1].getblockchaininfo()["blocks"])
self.log.info("Verify that invalidating an unknown block throws an error") self.log.info("Verify that invalidating an unknown block throws an error")
assert_raises_rpc_error(-5, "Block not found", self.nodes[1].invalidateblock, "00" * 32) assert_raises_rpc_error(-5, "Block not found", self.nodes[1].invalidateblock, "00" * 32)