foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

doc: add note about confusing HaveTxsDownloaded name

Browse source
This commit is contained in:
James O'Beirne 2023-09-11 13:41:28 -04:00
parent 7ee46a755f
commit 99839bbfa7
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/chain.h
View file

@ -276,6 +276,12 @@ public:
* *
* Does not imply the transactions are consensus-valid (ConnectTip might fail) * Does not imply the transactions are consensus-valid (ConnectTip might fail)
* Does not imply the transactions are still stored on disk. (IsBlockPruned might return true) * Does not imply the transactions are still stored on disk. (IsBlockPruned might return true)
*
* Note that this will be true for the snapshot base block, if one is loaded (and
* all subsequent assumed-valid blocks) since its nChainTx value will have been set
* manually based on the related AssumeutxoData entry.
*
* TODO: potentially change the name of this based on the fact above.
*/ */
bool HaveTxsDownloaded() const { return nChainTx != 0; } bool HaveTxsDownloaded() const { return nChainTx != 0; }