foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

Fix race condition for SetBannedSetDirty() calls

Browse source 
Another thread can `SetBannedSetDirty(true)` while `CBanDB::Write()`
call being executed. The following `SetBannedSetDirty(false)`
effectively makes `m_is_dirty` flag value inconsistent with the actual
`m_banned` state. Such behavior can result in data loss, e.g., during
shutdown.
This commit is contained in:
Hennadii Stepanov 2022-01-26 16:58:32 +02:00
parent 83c7646715
commit 99a6b699cd
No known key found for this signature in database
GPG key ID: 410108112E7EA81F
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/banman.cpp
View file

@ -49,11 +49,12 @@ void BanMan::DumpBanlist()
SweepBanned();
if (!BannedSetIsDirty()) return;
banmap = m_banned;
SetBannedSetDirty(false);
}
int64_t n_start = GetTimeMillis();
if (m_ban_db.Write(banmap)) {
SetBannedSetDirty(false);
if (!m_ban_db.Write(banmap)) {
SetBannedSetDirty(true);
}
LogPrint(BCLog::NET, "Flushed %d banned node addresses/subnets to disk %dms\n", banmap.size(),