foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-03 09:56:38 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#27418: test: Remove windows workaround in authproxy

Browse source 
fa584b4d01 test: Remove windows workaround in authproxy (MarcoFalke)

Pull request description:

  I wonder if the windows issues have also been fixed by bumping the server timeout in commit 88134fcee9.

  I guess the only way to find out and try.

  Note that even with the workaround, the issue would still happen occasionally: https://github.com/bitcoin/bitcoin/issues/18623

ACKs for top commit:
  fanquake:
    ACK fa584b4d01

Tree-SHA512: 1c633d7d8b54fa47bb851457d48b7d80bf6d6ea353db80610231e0bd385061b795f97ea2b64022fa24e79b4d7dcb5e947e0d637da228f10998e950d84b920878
This commit is contained in:
fanquake 2023-04-05 11:59:37 +01:00
commit 9ec30db888
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/functional/test_framework/authproxy.py
View file

@ -39,7 +39,6 @@ from http import HTTPStatus
import http.client import http.client
import json import json
import logging import logging
import os
import socket import socket
import time import time
import urllib.parse import urllib.parse
@ -100,11 +99,6 @@ class AuthServiceProxy():
'User-Agent': USER_AGENT, 'User-Agent': USER_AGENT,
'Authorization': self.__auth_header, 'Authorization': self.__auth_header,
'Content-type': 'application/json'} 'Content-type': 'application/json'}
if os.name == 'nt':
# Windows somehow does not like to re-use connections
# TODO: Find out why the connection would disconnect occasionally and make it reusable on Windows
# Avoid "ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine"
self._set_conn()
self.__conn.request(method, path, postdata, headers) self.__conn.request(method, path, postdata, headers)
return self._get_response() return self._get_response()