foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-03 09:56:38 -05:00
Code Issues Activity

Code cleanup: use ECDSA_size() instead of fixed 10,000 byte sig buffer, and explicity init static var

Browse source
This commit is contained in:
Gavin Andresen 2011-12-19 19:04:47 -05:00
parent 26ce92b352
commit 9ef7fa3447
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/key.h
View file

@ -177,14 +177,15 @@ public:
} }
bool Sign(uint256 hash, std::vector<unsigned char>& vchSig) bool Sign(uint256 hash, std::vector<unsigned char>& vchSig)
{
unsigned int nSize = ECDSA_size(pkey);
vchSig.resize(nSize); // Make sure it is big enough
if (!ECDSA_sign(0, (unsigned char*)&hash, sizeof(hash), &vchSig[0], &nSize, pkey))
{ {
vchSig.clear(); vchSig.clear();
unsigned char pchSig[10000];
unsigned int nSize = 0;
if (!ECDSA_sign(0, (unsigned char*)&hash, sizeof(hash), pchSig, &nSize, pkey))
return false; return false;
vchSig.resize(nSize); }
memcpy(&vchSig[0], pchSig, nSize); vchSig.resize(nSize); // Shrink to fit actual size
return true; return true;
} }

2
src/main.cpp
View file

@ -1875,7 +1875,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv)
} }
// Ask the first connected node for block updates // Ask the first connected node for block updates
static int nAskedForBlocks; static int nAskedForBlocks = 0;
if (!pfrom->fClient && if (!pfrom->fClient &&
(pfrom->nVersion < 32000 || pfrom->nVersion >= 32400) && (pfrom->nVersion < 32000 || pfrom->nVersion >= 32400) &&
(nAskedForBlocks < 1 || vNodes.size() <= 1)) (nAskedForBlocks < 1 || vNodes.size() <= 1))