foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity

fuzz: allow reaching MempoolAcceptResult::ResultType::DIFFERENT_WITNESS in tx_package_eval target

Browse source
This commit is contained in:
Greg Sanders 2023-09-28 09:04:01 -04:00
parent 21d985784f
commit a0626ccdad
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/test/fuzz/package_eval.cpp
View file

@ -40,7 +40,7 @@ void initialize_tx_pool()
g_setup = testing_setup.get(); g_setup = testing_setup.get();
for (int i = 0; i < 2 * COINBASE_MATURITY; ++i) { for (int i = 0; i < 2 * COINBASE_MATURITY; ++i) {
COutPoint prevout{MineBlock(g_setup->m_node, P2WSH_OP_TRUE)}; COutPoint prevout{MineBlock(g_setup->m_node, P2WSH_EMPTY)};
if (i < COINBASE_MATURITY) { if (i < COINBASE_MATURITY) {
// Remember the txids to avoid expensive disk access later on // Remember the txids to avoid expensive disk access later on
g_outpoints_coinbase_init_mature.push_back(prevout); g_outpoints_coinbase_init_mature.push_back(prevout);
@ -195,7 +195,8 @@ FUZZ_TARGET(tx_package_eval, .init = initialize_tx_pool)
// Create input // Create input
const auto sequence = ConsumeSequence(fuzzed_data_provider); const auto sequence = ConsumeSequence(fuzzed_data_provider);
const auto script_sig = CScript{}; const auto script_sig = CScript{};
const auto script_wit_stack = std::vector<std::vector<uint8_t>>{WITNESS_STACK_ELEM_OP_TRUE}; const auto script_wit_stack = fuzzed_data_provider.ConsumeBool() ? P2WSH_EMPTY_TRUE_STACK : P2WSH_EMPTY_TWO_STACK;
CTxIn in; CTxIn in;
in.prevout = outpoint; in.prevout = outpoint;
in.nSequence = sequence; in.nSequence = sequence;
@ -207,7 +208,7 @@ FUZZ_TARGET(tx_package_eval, .init = initialize_tx_pool)
const auto amount_fee = fuzzed_data_provider.ConsumeIntegralInRange<CAmount>(0, amount_in); const auto amount_fee = fuzzed_data_provider.ConsumeIntegralInRange<CAmount>(0, amount_in);
const auto amount_out = (amount_in - amount_fee) / num_out; const auto amount_out = (amount_in - amount_fee) / num_out;
for (int i = 0; i < num_out; ++i) { for (int i = 0; i < num_out; ++i) {
tx_mut.vout.emplace_back(amount_out, P2WSH_OP_TRUE); tx_mut.vout.emplace_back(amount_out, P2WSH_EMPTY);
} }
// TODO vary transaction sizes to catch size-related issues // TODO vary transaction sizes to catch size-related issues
auto tx = MakeTransactionRef(tx_mut); auto tx = MakeTransactionRef(tx_mut);

12
src/test/util/script.h
View file

@ -18,6 +18,18 @@ static const CScript P2WSH_OP_TRUE{
return hash; return hash;
}())}; }())};
static const std::vector<uint8_t> EMPTY{};
static const CScript P2WSH_EMPTY{
CScript{}
<< OP_0
<< ToByteVector([] {
uint256 hash;
CSHA256().Write(EMPTY.data(), EMPTY.size()).Finalize(hash.begin());
return hash;
}())};
static const std::vector<std::vector<uint8_t>> P2WSH_EMPTY_TRUE_STACK{{static_cast<uint8_t>(OP_TRUE)}, {}};
static const std::vector<std::vector<uint8_t>> P2WSH_EMPTY_TWO_STACK{{static_cast<uint8_t>(OP_2)}, {}};
/** Flags that are not forbidden by an assert in script validation */ /** Flags that are not forbidden by an assert in script validation */
bool IsValidFlagCombination(unsigned flags); bool IsValidFlagCombination(unsigned flags);