From 897d6dd42b78ab8569cbd7ae5e27f277b9acaeff Mon Sep 17 00:00:00 2001 From: Brandon Odiwuor Date: Mon, 30 Oct 2023 13:06:37 +0300 Subject: [PATCH] Remove feature_txindex_compatibility.py in V27 --- .../feature_txindex_compatibility.py | 66 ------------------- test/functional/test_runner.py | 1 - 2 files changed, 67 deletions(-) delete mode 100755 test/functional/feature_txindex_compatibility.py diff --git a/test/functional/feature_txindex_compatibility.py b/test/functional/feature_txindex_compatibility.py deleted file mode 100755 index 939271b385..0000000000 --- a/test/functional/feature_txindex_compatibility.py +++ /dev/null @@ -1,66 +0,0 @@ -#!/usr/bin/env python3 -# Copyright (c) 2021-2022 The Bitcoin Core developers -# Distributed under the MIT software license, see the accompanying -# file COPYING or http://www.opensource.org/licenses/mit-license.php. -"""Test that legacy txindex will be disabled on upgrade. - -Previous releases are required by this test, see test/README.md. -""" - -import shutil - -from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import assert_raises_rpc_error -from test_framework.wallet import MiniWallet - - -class TxindexCompatibilityTest(BitcoinTestFramework): - def set_test_params(self): - self.num_nodes = 2 - self.extra_args = [ - ["-reindex", "-txindex"], - [], - ] - - def skip_test_if_missing_module(self): - self.skip_if_no_previous_releases() - - def setup_network(self): - self.add_nodes( - self.num_nodes, - self.extra_args, - versions=[ - 160300, # Last release with legacy txindex - None, # For MiniWallet, without migration code - ], - ) - self.start_nodes() - self.connect_nodes(0, 1) - - def run_test(self): - mini_wallet = MiniWallet(self.nodes[1]) - spend_utxo = mini_wallet.get_utxo() - mini_wallet.send_self_transfer(from_node=self.nodes[1], utxo_to_spend=spend_utxo) - self.generate(self.nodes[1], 1) - - self.log.info("Check legacy txindex") - assert_raises_rpc_error(-5, "Use -txindex", lambda: self.nodes[1].getrawtransaction(txid=spend_utxo["txid"])) - self.nodes[0].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex - - self.stop_nodes() - legacy_chain_dir = self.nodes[0].chain_path - - self.log.info("Drop legacy txindex") - drop_index_chain_dir = self.nodes[1].chain_path - shutil.rmtree(drop_index_chain_dir) - shutil.copytree(legacy_chain_dir, drop_index_chain_dir) - # Build txindex from scratch and check there is no error this time - self.start_node(1, extra_args=["-txindex"]) - self.wait_until(lambda: self.nodes[1].getindexinfo()["txindex"]["synced"] == True) - self.nodes[1].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex - - self.stop_nodes() - - -if __name__ == "__main__": - TxindexCompatibilityTest().main() diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index fbf48a0e4d..341a31909b 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -357,7 +357,6 @@ BASE_SCRIPTS = [ 'rpc_scanblocks.py', 'p2p_sendtxrcncl.py', 'rpc_scantxoutset.py', - 'feature_txindex_compatibility.py', 'feature_unsupported_utxo_db.py', 'feature_logging.py', 'feature_anchors.py',