foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

Merge #17550: build: set minimum supported macOS to 10.12

Browse source 
7d7bf2ff4a build: set minimum supported macOS to 10.12 (fanquake)

Pull request description:

  Extracted from #16392 as this doesn't need to wait for the other build changes.

  Reasoning:
  * `10.10` has been unsupported since July 2017 (~3 years at `v0.20.0` release)
  * `10.11` has been unsupported since July 2018  (~2 years at `v0.20.0` release)
  * macOS users are consistent at upgrading to new releases.
  * Qt 5.12 LTS only supports [macOS > 10.12](https://doc-snapshots.qt.io/qt5-5.12/supported-platforms.html). As long as we're supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the `v0.20.0` release.

  Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:
  * Enabling support for [`thread_local`](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L901).
  * Removing some of the macOS notification code
  * Removing macOS [startup item code](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L695).

  There was also some related discussion in the `#bitcoin-builds` channel yesterday arvo.

ACKs for top commit:
  laanwj:
    ACK 7d7bf2ff4a
  dongcarl:
    post-IRC-grilling-ACK 7d7bf2ff4a

Tree-SHA512: 30b0ed75e3b4df2d3f94db2091b7982c1ea7be8fb3a2732d8efd1a53ef1e492d7265a47e90c38e92f66e638d10e9400a6ecb56e5093688bb26d1621645b453e8
This commit is contained in:
fanquake 2019-11-22 15:35:34 -05:00
commit a6f5b6f47d
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
9 changed files with 14 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.travis.yml
View file

@ -144,7 +144,7 @@ jobs:
FILE_ENV="./ci/test/00_setup_env_native_nowallet.sh" FILE_ENV="./ci/test/00_setup_env_native_nowallet.sh"
- stage: test - stage: test
name: 'macOS 10.10 [GOAL: deploy] [no functional tests]' name: 'macOS 10.12 [GOAL: deploy] [no functional tests]'
env: >- env: >-
FILE_ENV="./ci/test/00_setup_env_mac.sh" FILE_ENV="./ci/test/00_setup_env_mac.sh"
@ -152,8 +152,8 @@ jobs:
name: 'macOS 10.14 native [GOAL: install] [GUI] [no depends]' name: 'macOS 10.14 native [GOAL: install] [GUI] [no depends]'
os: osx os: osx
# Use the most recent version: # Use the most recent version:
# Xcode 11, macOS 10.14, JDK 12.0.1 # Xcode 11.2.1, macOS 10.14, JDK 13.0.1, SDK 10.15
# https://docs.travis-ci.com/user/reference/osx/#macos-version # https://docs.travis-ci.com/user/reference/osx/#macos-version
osx_image: xcode11 osx_image: xcode11.2
env: >- env: >-
FILE_ENV="./ci/test/00_setup_env_mac_host.sh" FILE_ENV="./ci/test/00_setup_env_mac_host.sh"

2
ci/test/00_setup_env_mac.sh
View file

@ -6,7 +6,7 @@
export LC_ALL=C.UTF-8 export LC_ALL=C.UTF-8
export HOST=x86_64-apple-darwin14 export HOST=x86_64-apple-darwin16
export PACKAGES="cmake imagemagick libcap-dev librsvg2-bin libz-dev libbz2-dev libtiff-tools python3-dev python3-setuptools" export PACKAGES="cmake imagemagick libcap-dev librsvg2-bin libz-dev libbz2-dev libtiff-tools python3-dev python3-setuptools"
export OSX_SDK=10.11 export OSX_SDK=10.11
export RUN_UNIT_TESTS=false export RUN_UNIT_TESTS=false

2
ci/test/00_setup_env_mac_host.sh
View file

@ -6,7 +6,7 @@
export LC_ALL=C.UTF-8 export LC_ALL=C.UTF-8
export HOST=x86_64-apple-darwin14 export HOST=x86_64-apple-darwin16
export BREW_PACKAGES="automake berkeley-db4 libtool boost miniupnpc pkg-config qt qrencode python3 ccache zeromq" export BREW_PACKAGES="automake berkeley-db4 libtool boost miniupnpc pkg-config qt qrencode python3 ccache zeromq"
export PIP_PACKAGES="zmq" export PIP_PACKAGES="zmq"
export RUN_CI_ON_HOST=true export RUN_CI_ON_HOST=true

2
contrib/gitian-descriptors/gitian-osx.yml
View file

@ -37,7 +37,7 @@ script: |
set -e -o pipefail set -e -o pipefail
WRAP_DIR=$HOME/wrapped WRAP_DIR=$HOME/wrapped
HOSTS="x86_64-apple-darwin14" HOSTS="x86_64-apple-darwin16"
CONFIGFLAGS="--enable-reduce-exports --disable-bench --disable-gui-tests GENISOIMAGE=$WRAP_DIR/genisoimage" CONFIGFLAGS="--enable-reduce-exports --disable-bench --disable-gui-tests GENISOIMAGE=$WRAP_DIR/genisoimage"
FAKETIME_HOST_PROGS="" FAKETIME_HOST_PROGS=""
FAKETIME_PROGS="ar ranlib date dmg genisoimage" FAKETIME_PROGS="ar ranlib date dmg genisoimage"

2
depends/README.md
View file

@ -25,7 +25,7 @@ Common `host-platform-triplets` for cross compilation are:
- `i686-pc-linux-gnu` for Linux 32 bit - `i686-pc-linux-gnu` for Linux 32 bit
- `x86_64-pc-linux-gnu` for x86 Linux - `x86_64-pc-linux-gnu` for x86 Linux
- `x86_64-w64-mingw32` for Win64 - `x86_64-w64-mingw32` for Win64
- `x86_64-apple-darwin14` for macOS - `x86_64-apple-darwin16` for macOS
- `arm-linux-gnueabihf` for Linux ARM 32 bit - `arm-linux-gnueabihf` for Linux ARM 32 bit
- `aarch64-linux-gnu` for Linux ARM 64 bit - `aarch64-linux-gnu` for Linux ARM 64 bit
- `riscv32-linux-gnu` for Linux RISC-V 32 bit - `riscv32-linux-gnu` for Linux RISC-V 32 bit

2
depends/hosts/darwin.mk
View file

@ -1,4 +1,4 @@
OSX_MIN_VERSION=10.10 OSX_MIN_VERSION=10.12
OSX_SDK_VERSION=10.11 OSX_SDK_VERSION=10.11
OSX_SDK=$(SDK_PATH)/MacOSX$(OSX_SDK_VERSION).sdk OSX_SDK=$(SDK_PATH)/MacOSX$(OSX_SDK_VERSION).sdk
LD64_VERSION=253.9 LD64_VERSION=253.9

2
doc/build-osx.md
View file

@ -110,7 +110,7 @@ tail -f $HOME/Library/Application\ Support/Bitcoin/debug.log
``` ```
## Notes ## Notes
* Tested on OS X 10.10 Yosemite through macOS 10.14 Mojave on 64-bit Intel * Tested on OS X 10.12 Sierra through macOS 10.15 Catalina on 64-bit Intel
processors only. processors only.
* Building with downloaded Qt binaries is not officially supported. See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714). * Building with downloaded Qt binaries is not officially supported. See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714).

9
doc/release-notes.md
View file

@ -46,16 +46,15 @@ Compatibility
============== ==============
Bitcoin Core is supported and extensively tested on operating systems using Bitcoin Core is supported and extensively tested on operating systems using
the Linux kernel, macOS 10.10+, and Windows 7 and newer. It is not recommended the Linux kernel, macOS 10.12+, and Windows 7 and newer. It is not recommended
to use Bitcoin Core on unsupported systems. to use Bitcoin Core on unsupported systems.
Bitcoin Core should also work on most other Unix-like systems but is not Bitcoin Core should also work on most other Unix-like systems but is not
as frequently tested on them. as frequently tested on them.
From Bitcoin Core 0.17.0 onwards, macOS versions earlier than 10.10 are no From Bitcoin Core 0.20.0 onwards, macOS versions earlier than 10.12 are no
longer supported, as Bitcoin Core is now built using Qt 5.9.x which requires longer supported. Additionally, Bitcoin Core does not yet change appearance
macOS 10.10+. Additionally, Bitcoin Core does not yet change appearance when when macOS "dark mode" is activated.
macOS "dark mode" is activated.
In addition to previously supported CPU platforms, this release's pre-compiled In addition to previously supported CPU platforms, this release's pre-compiled
distribution provides binaries for the RISC-V platform. distribution provides binaries for the RISC-V platform.

2
share/qt/Info.plist.in
View file

@ -3,7 +3,7 @@
<plist version="0.9"> <plist version="0.9">
<dict> <dict>
<key>LSMinimumSystemVersion</key> <key>LSMinimumSystemVersion</key>
<string>10.10.0</string> <string>10.12.0</string>
<key>LSArchitecturePriority</key> <key>LSArchitecturePriority</key>
<array> <array>