foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#25713: tidy: run clang-tidy in quiet mode

Browse source 
3fe58a98d3 tidy: run clang-tidy in quiet mode (fanquake)

Pull request description:

  This should cut the amount of output by atleast half.

  ```bash
  /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=bitcoin bitcoin/src/wallet/test/fuzz/coinselection.cpp
  278 warnings generated.
  Suppressed 278 warnings (278 in non-user code).
  Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
  ```
  becomes
  ```bash
  /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=/bitcoin -quiet bitcoin/src/wallet/test/fuzz/coinselection.cpp
  278 warnings generated.
  ```

  See https://clang.llvm.org/extra/clang-tidy/.

  >   --quiet
  > Run clang-tidy in quiet mode. This suppresses
  > printing statistics about ignored warnings and
  > warnings treated as errors if the respective
  > options are specified.

  However the `run-clang-tidy` option is `-quiet`. See f28c006a58/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py (L244).

ACKs for top commit:
  jamesob:
    ACK 3fe58a98d3

Tree-SHA512: 936cfab09a78e71a4a2a2b3539087c1a95fe279923cc8c3f950c70924d6920dcd54b0da8b5493a1337c23a3b25834ab0db5a6b0c660c6e46d750f0fc966e7625
This commit is contained in:
MacroFake 2022-07-30 09:26:19 +02:00
commit ab3db34836
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ci/test/06_script_b.sh
View file

@ -35,8 +35,9 @@ if [ "$RUN_FUNCTIONAL_TESTS" = "true" ]; then
fi
if [ "${RUN_TIDY}" = "true" ]; then
set -eo pipefail
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/src/"
CI_EXEC run-clang-tidy "${MAKEJOBS}"
( CI_EXEC run-clang-tidy -quiet "${MAKEJOBS}" ) | grep -C5 "error"
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/"
CI_EXEC "python3 ${DIR_IWYU}/include-what-you-use/iwyu_tool.py"\
" src/compat"\