foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-13 11:25:02 -05:00
Code Issues Activity

Remove redundant nullptr checks before deallocation

Browse source 
Rationale:
* delete ptr is a no-op if ptr is nullptr
This commit is contained in:
practicalswift 2017-06-28 23:14:48 +02:00
parent 140de14a12
commit b109a1c396
3 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/net.cpp
View file

@ -2753,7 +2753,6 @@ CNode::~CNode()
{ {
CloseSocket(hSocket); CloseSocket(hSocket);
if (pfilter)
delete pfilter; delete pfilter;
} }

1
src/qt/paymentrequestplus.cpp
View file

@ -194,7 +194,6 @@ bool PaymentRequestPlus::getMerchant(X509_STORE* certStore, QString& merchant) c
qWarning() << "PaymentRequestPlus::getMerchant: SSL error: " << err.what(); qWarning() << "PaymentRequestPlus::getMerchant: SSL error: " << err.what();
} }
if (website)
delete[] website; delete[] website;
X509_STORE_CTX_free(store_ctx); X509_STORE_CTX_free(store_ctx);
for (unsigned int i = 0; i < certs.size(); i++) for (unsigned int i = 0; i < certs.size(); i++)

1
src/qt/paymentserver.cpp
View file

@ -364,7 +364,6 @@ void PaymentServer::initNetManager()
{ {
if (!optionsModel) if (!optionsModel)
return; return;
if (netManager != nullptr)
delete netManager; delete netManager;
// netManager is used to fetch paymentrequests given in bitcoin: URIs // netManager is used to fetch paymentrequests given in bitcoin: URIs