foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
Code Issues Activity

[fuzz] Improve fuzzing stability for minisketch harness

Browse source 
* Seed minisketch rng
* Use fuzzer chosen minisketch impl instead of benchmarking for the best
  impl
This commit is contained in:
dergoegge 2023-12-12 16:44:44 +00:00
parent d646ca35d9
commit b2fc7a2eda
1 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/test/fuzz/minisketch.cpp
View file

@ -12,14 +12,27 @@
#include <map> #include <map>
#include <numeric> #include <numeric>
using node::MakeMinisketch32; namespace {
Minisketch MakeFuzzMinisketch32(size_t capacity, uint32_t impl)
{
return Assert(Minisketch(32, impl, capacity));
}
} // namespace
FUZZ_TARGET(minisketch) FUZZ_TARGET(minisketch)
{ {
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()}; FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
const auto capacity{fuzzed_data_provider.ConsumeIntegralInRange<size_t>(1, 200)}; const auto capacity{fuzzed_data_provider.ConsumeIntegralInRange<size_t>(1, 200)};
Minisketch sketch_a{Assert(MakeMinisketch32(capacity))}; const uint32_t impl{fuzzed_data_provider.ConsumeIntegralInRange<uint32_t>(0, Minisketch::MaxImplementation())};
Minisketch sketch_b{Assert(MakeMinisketch32(capacity))}; if (!Minisketch::ImplementationSupported(32, impl)) return;
Minisketch sketch_a{MakeFuzzMinisketch32(capacity, impl)};
Minisketch sketch_b{MakeFuzzMinisketch32(capacity, impl)};
sketch_a.SetSeed(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
sketch_b.SetSeed(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
// Fill two sets and keep the difference in a map // Fill two sets and keep the difference in a map
std::map<uint32_t, bool> diff; std::map<uint32_t, bool> diff;
@ -47,8 +60,11 @@ FUZZ_TARGET(minisketch)
} }
const auto num_diff{std::accumulate(diff.begin(), diff.end(), size_t{0}, [](auto n, const auto& e) { return n + e.second; })}; const auto num_diff{std::accumulate(diff.begin(), diff.end(), size_t{0}, [](auto n, const auto& e) { return n + e.second; })};
Minisketch sketch_ar{MakeMinisketch32(capacity)}; Minisketch sketch_ar{MakeFuzzMinisketch32(capacity, impl)};
Minisketch sketch_br{MakeMinisketch32(capacity)}; Minisketch sketch_br{MakeFuzzMinisketch32(capacity, impl)};
sketch_ar.SetSeed(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
sketch_br.SetSeed(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
sketch_ar.Deserialize(sketch_a.Serialize()); sketch_ar.Deserialize(sketch_a.Serialize());
sketch_br.Deserialize(sketch_b.Serialize()); sketch_br.Deserialize(sketch_b.Serialize());