From c377ae9ba08150c467e8b6cfaac7865f4d31457c Mon Sep 17 00:00:00 2001 From: Greg Sanders Date: Mon, 25 Mar 2024 10:48:29 -0400 Subject: [PATCH] unit test: improve ImprovesFeerateDiagram coverage with one less vb case --- src/test/rbf_tests.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/rbf_tests.cpp b/src/test/rbf_tests.cpp index a683bf84d5..992f2087f3 100644 --- a/src/test/rbf_tests.cpp +++ b/src/test/rbf_tests.cpp @@ -393,6 +393,9 @@ BOOST_FIXTURE_TEST_CASE(improves_feerate, TestChain100Setup) BOOST_CHECK(res2.value().second == "insufficient feerate: does not improve feerate diagram"); pool.PrioritiseTransaction(entry1->GetSharedTx()->GetHash(), /*nFeeDelta=*/-1); + // With one less vB it does + BOOST_CHECK(ImprovesFeerateDiagram(pool, {entry1}, {entry1, entry2}, tx1_fee + tx2_fee, tx1_size + tx2_size - 1) == std::nullopt); + // Adding a grandchild makes the cluster size 3, which is uncalculable const auto tx3 = make_tx(/*inputs=*/ {tx2}, /*output_values=*/ {995 * CENT}); pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx3));