foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
Code Issues Activity

test: remove redundant two-way disconnect_nodes calls

Browse source
This commit is contained in:
Danny Lee 2020-05-05 10:46:25 -07:00 • committed by Elliott Jin
parent a9bd1f9adf
commit e6e7abd51a
5 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/functional/p2p_node_network_limited.py
View file

@ -42,9 +42,6 @@ class NodeNetworkLimitedTest(BitcoinTestFramework):
def disconnect_all(self): def disconnect_all(self):
disconnect_nodes(self.nodes[0], 1) disconnect_nodes(self.nodes[0], 1)
disconnect_nodes(self.nodes[1], 0)
disconnect_nodes(self.nodes[2], 1)
disconnect_nodes(self.nodes[2], 0)
disconnect_nodes(self.nodes[0], 2) disconnect_nodes(self.nodes[0], 2)
disconnect_nodes(self.nodes[1], 2) disconnect_nodes(self.nodes[1], 2)

2
test/functional/rpc_psbt.py
View file

@ -44,9 +44,7 @@ class PSBTTest(BitcoinTestFramework):
# Disconnect offline node from others # Disconnect offline node from others
disconnect_nodes(offline_node, 1) disconnect_nodes(offline_node, 1)
disconnect_nodes(online_node, 0)
disconnect_nodes(offline_node, 2) disconnect_nodes(offline_node, 2)
disconnect_nodes(mining_node, 0)
# Create watchonly on online_node # Create watchonly on online_node
online_node.createwallet(wallet_name='wonline', disable_private_keys=True) online_node.createwallet(wallet_name='wonline', disable_private_keys=True)

1
test/functional/test_framework/test_framework.py
View file

@ -508,7 +508,6 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
Split the network of four nodes into nodes 0/1 and 2/3. Split the network of four nodes into nodes 0/1 and 2/3.
""" """
disconnect_nodes(self.nodes[1], 2) disconnect_nodes(self.nodes[1], 2)
disconnect_nodes(self.nodes[2], 1)
self.sync_all(self.nodes[:2]) self.sync_all(self.nodes[:2])
self.sync_all(self.nodes[2:]) self.sync_all(self.nodes[2:])

1
test/functional/wallet_txn_clone.py
View file

@ -31,7 +31,6 @@ class TxnMallTest(BitcoinTestFramework):
# Start with split network: # Start with split network:
super().setup_network() super().setup_network()
disconnect_nodes(self.nodes[1], 2) disconnect_nodes(self.nodes[1], 2)
disconnect_nodes(self.nodes[2], 1)
def run_test(self): def run_test(self):
if self.options.segwit: if self.options.segwit:

1
test/functional/wallet_txn_doublespend.py
View file

@ -29,7 +29,6 @@ class TxnMallTest(BitcoinTestFramework):
# Start with split network: # Start with split network:
super().setup_network() super().setup_network()
disconnect_nodes(self.nodes[1], 2) disconnect_nodes(self.nodes[1], 2)
disconnect_nodes(self.nodes[2], 1)
def run_test(self): def run_test(self):
# All nodes should start with 1,250 BTC: # All nodes should start with 1,250 BTC: