foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#21783: refactor: Make MempoolAcceptResult members const

Browse source 
363df758a9 doc/style followups in MempoolAcceptResult (glozow)

Pull request description:

  Follow up to #21062. Was going to be a part of #20833 but I'm trying to break it down as much as possible.

  - Make members const (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r573659273)
  - List fee units (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r569329362)
  - Use default value for `TxValidationState` in the success case (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r573659801).

ACKs for top commit:
  jnewbery:
    ACK 363df758a9
  practicalswift:
    cr ACK 363df758a9: patch looks correct and `const` is better than non-`const` (where possible :))
  ariard:
    Code Review ACK 363df75

Tree-SHA512: 0ff1a0279e08e03204e48d0f4c92428d7f39c32f52c1d20fe6a0283d605839898297344be82ca69640ba9f878ca4ebd5da2d717e26d719a183b211d709334082
This commit is contained in:
MarcoFalke 2021-04-28 08:06:25 +02:00
commit edf679503c
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/validation.h
View file

@ -195,14 +195,14 @@ struct MempoolAcceptResult {
VALID, //!> Fully validated, valid. VALID, //!> Fully validated, valid.
INVALID, //!> Invalid. INVALID, //!> Invalid.
}; };
ResultType m_result_type; const ResultType m_result_type;
TxValidationState m_state; const TxValidationState m_state;
// The following fields are only present when m_result_type = ResultType::VALID // The following fields are only present when m_result_type = ResultType::VALID
/** Mempool transactions replaced by the tx per BIP 125 rules. */ /** Mempool transactions replaced by the tx per BIP 125 rules. */
std::optional<std::list<CTransactionRef>> m_replaced_transactions; const std::optional<std::list<CTransactionRef>> m_replaced_transactions;
/** Raw base fees. */ /** Raw base fees in satoshis. */
std::optional<CAmount> m_base_fees; const std::optional<CAmount> m_base_fees;
/** Constructor for failure case */ /** Constructor for failure case */
explicit MempoolAcceptResult(TxValidationState state) explicit MempoolAcceptResult(TxValidationState state)
@ -212,7 +212,7 @@ struct MempoolAcceptResult {
/** Constructor for success case */ /** Constructor for success case */
explicit MempoolAcceptResult(std::list<CTransactionRef>&& replaced_txns, CAmount fees) explicit MempoolAcceptResult(std::list<CTransactionRef>&& replaced_txns, CAmount fees)
: m_result_type(ResultType::VALID), m_state(TxValidationState{}), : m_result_type(ResultType::VALID),
m_replaced_transactions(std::move(replaced_txns)), m_base_fees(fees) {} m_replaced_transactions(std::move(replaced_txns)), m_base_fees(fees) {}
}; };