mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-08 10:31:50 -05:00
Merge bitcoin/bitcoin#26040: doc: comment "add only reachable addresses to addrman"
ce42570266
doc: comment "add only reachable addresses to addrman" (Kristaps Kaupe) Pull request description: Proposed by Sjors during review of #25678, was likely just missed, as it also for me looks a code where comment will not hurt. https://github.com/bitcoin/bitcoin/pull/25678#discussion_r964482832 ACKs for top commit: mzumsande: ACKce42570266
vasild: ACKce42570266
Zero-1729: re-ACKce42570266
Tree-SHA512: ef085d527349de07c1b43ed39e55e34b29cb0137c9509bd14a1af88206f7d4aa7dfec1dca53a9deaed67a2d0f32fa21e0b1a04d4d5d7f8a265dfab3b62bf8c54
This commit is contained in:
commit
ef5bb742f0
1 changed files with 8 additions and 0 deletions
|
@ -1648,6 +1648,14 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
|
|||
|
||||
if (add_fixed_seeds_now) {
|
||||
std::vector<CAddress> seed_addrs{ConvertSeeds(Params().FixedSeeds())};
|
||||
// We will not make outgoing connections to peers that are unreachable
|
||||
// (e.g. because of -onlynet configuration).
|
||||
// Therefore, we do not add them to addrman in the first place.
|
||||
// Note that if you change -onlynet setting from one network to another,
|
||||
// peers.dat will contain only peers of unreachable networks and
|
||||
// manual intervention will be needed (either delete peers.dat after
|
||||
// configuration change or manually add some reachable peer using addnode),
|
||||
// see <https://github.com/bitcoin/bitcoin/issues/26035> for details.
|
||||
seed_addrs.erase(std::remove_if(seed_addrs.begin(), seed_addrs.end(),
|
||||
[](const CAddress& addr) { return !IsReachable(addr); }),
|
||||
seed_addrs.end());
|
||||
|
|
Loading…
Add table
Reference in a new issue