foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

test: refactor: deduplicate handle_utxocache_* logic

Browse source 
Carve out the comparison logic into a helper function to avoid
code duplication.
This commit is contained in:
stickies-v 2023-06-23 11:32:10 +01:00
parent ad90ba36bd
commit f1b99ac94f
No known key found for this signature in database
GPG key ID: 5CB1CE6E5E66A757
1 changed files with 16 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
test/functional/interface_usdt_utxocache.py
View file

@ -258,37 +258,33 @@ class UTXOCacheTracepointTest(BitcoinTestFramework):
expected_utxocache_spents = []
expected_utxocache_adds = []
def compare_utxo_with_event(utxo, event):
"""Returns 1 if a utxo is identical to the event produced by BPF, otherwise"""
try:
assert_equal(utxo["txid"], bytes(event.txid[::-1]).hex())
assert_equal(utxo["index"], event.index)
assert_equal(utxo["height"], event.height)
assert_equal(utxo["value"], event.value)
assert_equal(utxo["is_coinbase"], event.is_coinbase)
except AssertionError:
self.log.exception("Assertion failed")
return 0
else:
return 1
def handle_utxocache_add(_, data, __):
nonlocal handle_add_succeeds
event = ctypes.cast(data, ctypes.POINTER(UTXOCacheChange)).contents
self.log.info(f"handle_utxocache_add(): {event}")
add = expected_utxocache_adds.pop(0)
try:
assert_equal(add["txid"], bytes(event.txid[::-1]).hex())
assert_equal(add["index"], event.index)
assert_equal(add["height"], event.height)
assert_equal(add["value"], event.value)
assert_equal(add["is_coinbase"], event.is_coinbase)
except AssertionError:
self.log.exception("Assertion failed")
else:
handle_add_succeeds += 1
handle_add_succeeds += compare_utxo_with_event(add, event)
def handle_utxocache_spent(_, data, __):
nonlocal handle_spent_succeeds
event = ctypes.cast(data, ctypes.POINTER(UTXOCacheChange)).contents
self.log.info(f"handle_utxocache_spent(): {event}")
spent = expected_utxocache_spents.pop(0)
try:
assert_equal(spent["txid"], bytes(event.txid[::-1]).hex())
assert_equal(spent["index"], event.index)
assert_equal(spent["height"], event.height)
assert_equal(spent["value"], event.value)
assert_equal(spent["is_coinbase"], event.is_coinbase)
except AssertionError:
self.log.exception("Assertion failed")
else:
handle_spent_succeeds += 1
handle_spent_succeeds += compare_utxo_with_event(spent, event)
bpf["utxocache_add"].open_perf_buffer(handle_utxocache_add)
bpf["utxocache_spent"].open_perf_buffer(handle_utxocache_spent)