foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

test: bumpfee with user specified fee_rate ignores walletIncrementalRelayFee

Browse source
This commit is contained in:
ismaelsadeeq 2023-06-26 22:06:25 +01:00
parent 436e88f433
commit f58beabe75
1 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
test/functional/wallet_bumpfee.py
View file

@ -116,6 +116,7 @@ class BumpFeeTest(BitcoinTestFramework):
# Context independent tests
test_feerate_checks_replaced_outputs(self, rbf_node, peer_node)
test_bumpfee_with_feerate_ignores_walletincrementalrelayfee(self, rbf_node, peer_node)
def test_invalid_parameters(self, rbf_node, peer_node, dest_address):
self.log.info('Test invalid parameters')
@ -829,5 +830,27 @@ def test_feerate_checks_replaced_outputs(self, rbf_node, peer_node):
self.clear_mempool()
def test_bumpfee_with_feerate_ignores_walletincrementalrelayfee(self, rbf_node, peer_node):
self.log.info('Test that bumpfee with fee_rate ignores walletincrementalrelayfee')
# Make sure there is enough balance
peer_node.sendtoaddress(rbf_node.getnewaddress(), 2)
self.generate(peer_node, 1)
dest_address = peer_node.getnewaddress(address_type="bech32")
tx = rbf_node.send(outputs=[{dest_address: 1}], fee_rate=2)
# Ensure you can not fee bump with a fee_rate below or equal to the original fee_rate
assert_raises_rpc_error(-8, "Insufficient total fee", rbf_node.bumpfee, tx["txid"], {"fee_rate": 1})
assert_raises_rpc_error(-8, "Insufficient total fee", rbf_node.bumpfee, tx["txid"], {"fee_rate": 2})
# Ensure you can not fee bump if the fee_rate is more than original fee_rate but the total fee from new fee_rate is
# less than (original fee + incrementalrelayfee)
assert_raises_rpc_error(-8, "Insufficient total fee", rbf_node.bumpfee, tx["txid"], {"fee_rate": 2.8})
# You can fee bump as long as the new fee set from fee_rate is atleast (original fee + incrementalrelayfee)
rbf_node.bumpfee(tx["txid"], {"fee_rate": 3})
self.clear_mempool()
if __name__ == "__main__":
BumpFeeTest().main()