foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity

Docs: Update python docs to reflect that wildcard imports are disallowed

Browse source
This commit is contained in:
Ben Woosley 2019-01-24 16:57:41 -08:00
parent 72bd4ab867
commit f618c58b75
No known key found for this signature in database
GPG key ID: 6EE5F3785F78B345
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/functional/README.md
View file

@ -26,7 +26,7 @@ don't have test cases for.
The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126). The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
- See [the python lint script](/test/lint/lint-python.sh) that checks for violations that - See [the python lint script](/test/lint/lint-python.sh) that checks for violations that
could lead to bugs and issues in the test code. could lead to bugs and issues in the test code.
- Avoid wildcard imports where possible - Avoid wildcard imports
- Use a module-level docstring to describe what the test is testing, and how it - Use a module-level docstring to describe what the test is testing, and how it
is testing it. is testing it.
- When subclassing the BitcoinTestFramwork, place overrides for the - When subclassing the BitcoinTestFramwork, place overrides for the

2
test/functional/example_test.py
View file

@ -13,7 +13,7 @@ is testing and *how* it's being tested
# libraries then local imports). # libraries then local imports).
from collections import defaultdict from collections import defaultdict
# Avoid wildcard * imports if possible # Avoid wildcard * imports
from test_framework.blocktools import (create_block, create_coinbase) from test_framework.blocktools import (create_block, create_coinbase)
from test_framework.messages import CInv from test_framework.messages import CInv
from test_framework.mininode import ( from test_framework.mininode import (