foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

refactor: Don't redundantly define porphanTx in net_processing.cpp

Browse source 
net_processing.cpp:3042:28: error: declaration shadows a local variable [-Werror,-Wshadow]
    while (CTransactionRef porphanTx = m_orphanage.GetTxToReconsider(peer.m_id)) {
                           ^
net_processing.cpp:3040:21: note: previous declaration is here
    CTransactionRef porphanTx = nullptr;
                    ^
This commit is contained in:
Benjamin Woosley 2024-02-24 17:15:31 -03:00
parent c17de5429e
commit f953bf4d99
No known key found for this signature in database
GPG key ID: 609F2AB495D8C15C
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/net_processing.cpp
View file

@ -3069,8 +3069,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
AssertLockHeld(g_msgproc_mutex);
LOCK2(::cs_main, m_tx_download_mutex);
CTransactionRef porphanTx = nullptr;
while (CTransactionRef porphanTx = m_txdownloadman.GetTxToReconsider(peer.m_id)) {
const MempoolAcceptResult result = m_chainman.ProcessTransaction(porphanTx);
const TxValidationState& state = result.m_state;