foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity

style: Add static keyword where possible in rpc/mempool

Browse source
This commit is contained in:
MarcoFalke 2022-03-24 08:25:47 +01:00
parent 98e9d8e8e2
commit fa0f666dd7
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/rpc/mempool.cpp
View file

@ -16,7 +16,9 @@
#include <univalue.h> #include <univalue.h>
#include <validation.h> #include <validation.h>
static std::vector<RPCResult> MempoolEntryDescription() { return { static std::vector<RPCResult> MempoolEntryDescription()
{
return {
RPCResult{RPCResult::Type::NUM, "vsize", "virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted."}, RPCResult{RPCResult::Type::NUM, "vsize", "virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted."},
RPCResult{RPCResult::Type::NUM, "weight", "transaction weight as defined in BIP 141."}, RPCResult{RPCResult::Type::NUM, "weight", "transaction weight as defined in BIP 141."},
RPCResult{RPCResult::Type::STR_AMOUNT, "fee", /*optional=*/true, RPCResult{RPCResult::Type::STR_AMOUNT, "fee", /*optional=*/true,
@ -50,7 +52,8 @@ static std::vector<RPCResult> MempoolEntryDescription() { return {
{RPCResult{RPCResult::Type::STR_HEX, "transactionid", "child transaction id"}}}, {RPCResult{RPCResult::Type::STR_HEX, "transactionid", "child transaction id"}}},
RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction could be replaced due to BIP125 (replace-by-fee)"}, RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction could be replaced due to BIP125 (replace-by-fee)"},
RPCResult{RPCResult::Type::BOOL, "unbroadcast", "Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers)"}, RPCResult{RPCResult::Type::BOOL, "unbroadcast", "Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers)"},
};} };
}
static void entryToJSON(const CTxMemPool& pool, UniValue& info, const CTxMemPoolEntry& e) EXCLUSIVE_LOCKS_REQUIRED(pool.cs) static void entryToJSON(const CTxMemPool& pool, UniValue& info, const CTxMemPoolEntry& e) EXCLUSIVE_LOCKS_REQUIRED(pool.cs)
{ {
@ -164,7 +167,7 @@ UniValue MempoolToJSON(const CTxMemPool& pool, bool verbose, bool include_mempoo
} }
} }
RPCHelpMan getrawmempool() static RPCHelpMan getrawmempool()
{ {
return RPCHelpMan{"getrawmempool", return RPCHelpMan{"getrawmempool",
"\nReturns all transaction ids in memory pool as a json array of string transaction ids.\n" "\nReturns all transaction ids in memory pool as a json array of string transaction ids.\n"
@ -214,7 +217,7 @@ RPCHelpMan getrawmempool()
}; };
} }
RPCHelpMan getmempoolancestors() static RPCHelpMan getmempoolancestors()
{ {
return RPCHelpMan{"getmempoolancestors", return RPCHelpMan{"getmempoolancestors",
"\nIf txid is in the mempool, returns all in-mempool ancestors.\n", "\nIf txid is in the mempool, returns all in-mempool ancestors.\n",
@ -278,7 +281,7 @@ RPCHelpMan getmempoolancestors()
}; };
} }
RPCHelpMan getmempooldescendants() static RPCHelpMan getmempooldescendants()
{ {
return RPCHelpMan{"getmempooldescendants", return RPCHelpMan{"getmempooldescendants",
"\nIf txid is in the mempool, returns all in-mempool descendants.\n", "\nIf txid is in the mempool, returns all in-mempool descendants.\n",
@ -343,7 +346,7 @@ RPCHelpMan getmempooldescendants()
}; };
} }
RPCHelpMan getmempoolentry() static RPCHelpMan getmempoolentry()
{ {
return RPCHelpMan{"getmempoolentry", return RPCHelpMan{"getmempoolentry",
"\nReturns mempool data for given transaction\n", "\nReturns mempool data for given transaction\n",
@ -394,7 +397,7 @@ UniValue MempoolInfoToJSON(const CTxMemPool& pool)
return ret; return ret;
} }
RPCHelpMan getmempoolinfo() static RPCHelpMan getmempoolinfo()
{ {
return RPCHelpMan{"getmempoolinfo", return RPCHelpMan{"getmempoolinfo",
"\nReturns details on the active state of the TX memory pool.\n", "\nReturns details on the active state of the TX memory pool.\n",
@ -423,7 +426,7 @@ RPCHelpMan getmempoolinfo()
}; };
} }
RPCHelpMan savemempool() static RPCHelpMan savemempool()
{ {
return RPCHelpMan{"savemempool", return RPCHelpMan{"savemempool",
"\nDumps the mempool to disk. It will fail until the previous dump is fully loaded.\n", "\nDumps the mempool to disk. It will fail until the previous dump is fully loaded.\n",