foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
Code Issues Activity

rpc: Avoid getchaintxstats invalid results

Browse source
This commit is contained in:
MarcoFalke 2024-03-25 11:33:07 +01:00
parent 0bd2bd1efb
commit fa2dada0c9
No known key found for this signature in database
3 changed files with 23 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/rpc/blockchain.cpp
View file

@ -1645,13 +1645,19 @@ static RPCHelpMan getchaintxstats()
RPCResult::Type::OBJ, "", "", RPCResult::Type::OBJ, "", "",
{ {
{RPCResult::Type::NUM_TIME, "time", "The timestamp for the final block in the window, expressed in " + UNIX_EPOCH_TIME}, {RPCResult::Type::NUM_TIME, "time", "The timestamp for the final block in the window, expressed in " + UNIX_EPOCH_TIME},
{RPCResult::Type::NUM, "txcount", "The total number of transactions in the chain up to that point"}, {RPCResult::Type::NUM, "txcount", /*optional=*/true,
"The total number of transactions in the chain up to that point, if known. "
"It may be unknown when using assumeutxo."},
{RPCResult::Type::STR_HEX, "window_final_block_hash", "The hash of the final block in the window"}, {RPCResult::Type::STR_HEX, "window_final_block_hash", "The hash of the final block in the window"},
{RPCResult::Type::NUM, "window_final_block_height", "The height of the final block in the window."}, {RPCResult::Type::NUM, "window_final_block_height", "The height of the final block in the window."},
{RPCResult::Type::NUM, "window_block_count", "Size of the window in number of blocks"}, {RPCResult::Type::NUM, "window_block_count", "Size of the window in number of blocks"},
{RPCResult::Type::NUM, "window_tx_count", /*optional=*/true, "The number of transactions in the window. Only returned if \"window_block_count\" is > 0"}, {RPCResult::Type::NUM, "window_tx_count", /*optional=*/true,
"The number of transactions in the window. "
"Only returned if \"window_block_count\" is > 0 and if txcount exists for the start and end of the window."},
{RPCResult::Type::NUM, "window_interval", /*optional=*/true, "The elapsed time in the window in seconds. Only returned if \"window_block_count\" is > 0"}, {RPCResult::Type::NUM, "window_interval", /*optional=*/true, "The elapsed time in the window in seconds. Only returned if \"window_block_count\" is > 0"},
{RPCResult::Type::NUM, "txrate", /*optional=*/true, "The average rate of transactions per second in the window. Only returned if \"window_interval\" is > 0"}, {RPCResult::Type::NUM, "txrate", /*optional=*/true,
"The average rate of transactions per second in the window. "
"Only returned if \"window_interval\" is > 0 and if window_tx_count exists."},
}}, }},
RPCExamples{ RPCExamples{
HelpExampleCli("getchaintxstats", "") HelpExampleCli("getchaintxstats", "")
@ -1692,19 +1698,25 @@ static RPCHelpMan getchaintxstats()
const CBlockIndex& past_block{*CHECK_NONFATAL(pindex->GetAncestor(pindex->nHeight - blockcount))}; const CBlockIndex& past_block{*CHECK_NONFATAL(pindex->GetAncestor(pindex->nHeight - blockcount))};
const int64_t nTimeDiff{pindex->GetMedianTimePast() - past_block.GetMedianTimePast()}; const int64_t nTimeDiff{pindex->GetMedianTimePast() - past_block.GetMedianTimePast()};
const int nTxDiff = pindex->nChainTx - past_block.nChainTx; const auto window_tx_count{
(pindex->nChainTx != 0 && past_block.nChainTx != 0) ? std::optional{pindex->nChainTx - past_block.nChainTx} : std::nullopt,
};
UniValue ret(UniValue::VOBJ); UniValue ret(UniValue::VOBJ);
ret.pushKV("time", (int64_t)pindex->nTime); ret.pushKV("time", (int64_t)pindex->nTime);
ret.pushKV("txcount", (int64_t)pindex->nChainTx); if (pindex->nChainTx) {
ret.pushKV("txcount", pindex->nChainTx);
}
ret.pushKV("window_final_block_hash", pindex->GetBlockHash().GetHex()); ret.pushKV("window_final_block_hash", pindex->GetBlockHash().GetHex());
ret.pushKV("window_final_block_height", pindex->nHeight); ret.pushKV("window_final_block_height", pindex->nHeight);
ret.pushKV("window_block_count", blockcount); ret.pushKV("window_block_count", blockcount);
if (blockcount > 0) { if (blockcount > 0) {
ret.pushKV("window_tx_count", nTxDiff); if (window_tx_count) {
ret.pushKV("window_tx_count", *window_tx_count);
}
ret.pushKV("window_interval", nTimeDiff); ret.pushKV("window_interval", nTimeDiff);
if (nTimeDiff > 0) { if (nTimeDiff > 0 && window_tx_count) {
ret.pushKV("txrate", ((double)nTxDiff) / nTimeDiff); ret.pushKV("txrate", double(*window_tx_count) / nTimeDiff);
} }
} }

6
test/functional/feature_assumeutxo.py
View file

@ -301,7 +301,7 @@ class AssumeutxoTest(BitcoinTestFramework):
the snapshot, and final values after the snapshot is validated.""" the snapshot, and final values after the snapshot is validated."""
for height, block in blocks.items(): for height, block in blocks.items():
tx = n1.getblockheader(block.hash)["nTx"] tx = n1.getblockheader(block.hash)["nTx"]
chain_tx = n1.getchaintxstats(nblocks=1, blockhash=block.hash)["txcount"] chain_tx = n1.getchaintxstats(nblocks=1, blockhash=block.hash).get("txcount", None)
# Intermediate nTx of the starting block should be set, but nTx of # Intermediate nTx of the starting block should be set, but nTx of
# later blocks should be 0 before they are downloaded. # later blocks should be 0 before they are downloaded.
@ -311,11 +311,11 @@ class AssumeutxoTest(BitcoinTestFramework):
assert_equal(tx, 0) assert_equal(tx, 0)
# Intermediate nChainTx of the starting block and snapshot block # Intermediate nChainTx of the starting block and snapshot block
# should be set, but others should be 0 until they are downloaded. # should be set, but others should be None until they are downloaded.
if final or height in (START_HEIGHT, SNAPSHOT_BASE_HEIGHT): if final or height in (START_HEIGHT, SNAPSHOT_BASE_HEIGHT):
assert_equal(chain_tx, block.chain_tx) assert_equal(chain_tx, block.chain_tx)
else: else:
assert_equal(chain_tx, 0) assert_equal(chain_tx, None)
check_tx_counts(final=False) check_tx_counts(final=False)

2
test/sanitizer_suppressions/ubsan
View file

@ -51,7 +51,6 @@ unsigned-integer-overflow:CCoinsViewCache::Uncache
unsigned-integer-overflow:CompressAmount unsigned-integer-overflow:CompressAmount
unsigned-integer-overflow:DecompressAmount unsigned-integer-overflow:DecompressAmount
unsigned-integer-overflow:crypto/ unsigned-integer-overflow:crypto/
unsigned-integer-overflow:getchaintxstats*
unsigned-integer-overflow:MurmurHash3 unsigned-integer-overflow:MurmurHash3
unsigned-integer-overflow:CBlockPolicyEstimator::processBlockTx unsigned-integer-overflow:CBlockPolicyEstimator::processBlockTx
unsigned-integer-overflow:TxConfirmStats::EstimateMedianVal unsigned-integer-overflow:TxConfirmStats::EstimateMedianVal
@ -63,7 +62,6 @@ implicit-integer-sign-change:CBlockPolicyEstimator::processBlockTx
implicit-integer-sign-change:SetStdinEcho implicit-integer-sign-change:SetStdinEcho
implicit-integer-sign-change:compressor.h implicit-integer-sign-change:compressor.h
implicit-integer-sign-change:crypto/ implicit-integer-sign-change:crypto/
implicit-integer-sign-change:getchaintxstats*
implicit-integer-sign-change:TxConfirmStats::removeTx implicit-integer-sign-change:TxConfirmStats::removeTx
implicit-integer-sign-change:prevector.h implicit-integer-sign-change:prevector.h
implicit-integer-sign-change:verify_flags implicit-integer-sign-change:verify_flags