foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity

[doc] rpcwallet: Only fail rescan when blocks have been pruned

Browse source
This commit is contained in:
MarcoFalke 2019-05-15 14:10:41 -04:00
parent aaaa57c2aa
commit fa7e311e16
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
doc/release-notes.md
View file

@ -88,6 +88,16 @@ Configuration
the selected network. This change takes only effect if the selected network the selected network. This change takes only effect if the selected network
is not mainnet. is not mainnet.
Wallet
------
- When in pruned mode, a rescan that was triggered by an `importwallet`,
`importpubkey`, `importaddress`, or `importprivkey` RPC will only fail when
blocks have been pruned. Previously it would fail when `-prune` has been set.
This change allows to set `-prune` to a high value (e.g. the disk size) and
the calls to any of the import RPCs would fail when the first block is
pruned.
Credits Credits
======= =======

2
src/wallet/rpcdump.cpp
View file

@ -586,7 +586,7 @@ UniValue importwallet(const JSONRPCRequest& request)
// Exit early and print an error. // Exit early and print an error.
// If a block is pruned after this check, we will import the key(s), // If a block is pruned after this check, we will import the key(s),
// but fail the rescan with a generic error. // but fail the rescan with a generic error.
throw JSONRPCError(RPC_WALLET_ERROR, "Importing wallets is disabled in pruned mode"); throw JSONRPCError(RPC_WALLET_ERROR, "Importing wallets is disabled when blocks are pruned");
} }
WalletRescanReserver reserver(pwallet); WalletRescanReserver reserver(pwallet);