From faa90f6e7b6b8c531e1ae142a5c2f568b48502a9 Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Thu, 12 Oct 2023 11:11:48 +0200
Subject: [PATCH] refactor: Remove unused nchaintx from SnapshotMetadata
 constructor

Also, remove wrong nChainTx comment and cast.
---
 src/node/utxo_snapshot.h | 3 +--
 src/rpc/blockchain.cpp   | 6 ++----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/node/utxo_snapshot.h b/src/node/utxo_snapshot.h
index a6dd3f3f13..1160bb55f0 100644
--- a/src/node/utxo_snapshot.h
+++ b/src/node/utxo_snapshot.h
@@ -35,8 +35,7 @@ public:
     SnapshotMetadata() { }
     SnapshotMetadata(
         const uint256& base_blockhash,
-        uint64_t coins_count,
-        unsigned int nchaintx) :
+        uint64_t coins_count) :
             m_base_blockhash(base_blockhash),
             m_coins_count(coins_count) { }
 
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
index 31dd8164fe..37a28e414a 100644
--- a/src/rpc/blockchain.cpp
+++ b/src/rpc/blockchain.cpp
@@ -2667,7 +2667,7 @@ UniValue CreateUTXOSnapshot(
         tip->nHeight, tip->GetBlockHash().ToString(),
         fs::PathToString(path), fs::PathToString(temppath)));
 
-    SnapshotMetadata metadata{tip->GetBlockHash(), maybe_stats->coins_count, tip->nChainTx};
+    SnapshotMetadata metadata{tip->GetBlockHash(), maybe_stats->coins_count};
 
     afile << metadata;
 
@@ -2694,9 +2694,7 @@ UniValue CreateUTXOSnapshot(
     result.pushKV("base_height", tip->nHeight);
     result.pushKV("path", path.u8string());
     result.pushKV("txoutset_hash", maybe_stats->hashSerialized.ToString());
-    // Cast required because univalue doesn't have serialization specified for
-    // `unsigned int`, nChainTx's type.
-    result.pushKV("nchaintx", uint64_t{tip->nChainTx});
+    result.pushKV("nchaintx", tip->nChainTx);
     return result;
 }