foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#28396: test: p2p: check that getaddr msgs are only responded once per connection

Browse source 
668aa6af8d test: p2p: check that `getaddr` msgs are only responded once per connection (Sebastian Falbesoner)

Pull request description:

  This simple PR adds missing test coverage for ignoring repeated `getaddr` requests (introduced in #7856, commit 66b07247a7):
  6f03c45f6b/src/net_processing.cpp (L4642-L4648)

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 668aa6af8d
  brunoerg:
    crACK 668aa6af8d

Tree-SHA512: edcdc6501c684fb41911e393f55ded9b044cd2f92918877eca152edd5a4287d1a9d57ae999f1cb42185eae00c3a0af411fcb9bcd5b990ef48849c3834b141584
This commit is contained in:
fanquake 2023-09-05 11:45:27 +03:00
commit fb619e1bc3
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
test/functional/p2p_addr_relay.py
View file

@ -299,6 +299,16 @@ class AddrTest(BitcoinTestFramework):
assert_equal(block_relay_peer.num_ipv4_received, 0)
assert inbound_peer.num_ipv4_received > 100
self.log.info('Check that we answer getaddr messages only once per connection')
received_addrs_before = inbound_peer.num_ipv4_received
with self.nodes[0].assert_debug_log(['Ignoring repeated "getaddr".']):
inbound_peer.send_and_ping(msg_getaddr())
self.mocktime += 10 * 60
self.nodes[0].setmocktime(self.mocktime)
inbound_peer.sync_with_ping()
received_addrs_after = inbound_peer.num_ipv4_received
assert_equal(received_addrs_before, received_addrs_after)
self.nodes[0].disconnect_p2ps()
def blocksonly_mode_tests(self):