foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
Code Issues Activity

RPC: Extract ReconsiderBlock helper

Browse source
This commit is contained in:
Fabian Jahr 2024-03-02 16:42:27 +01:00
parent 446ce51c21
commit fccf4f91d2
No known key found for this signature in database
GPG key ID: F13D1E9D890798CD
1 changed files with 20 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
src/rpc/blockchain.cpp
View file

@ -1622,6 +1622,25 @@ static RPCHelpMan invalidateblock()
};
}
void ReconsiderBlock(ChainstateManager& chainman, uint256 block_hash) {
{
LOCK(chainman.GetMutex());
CBlockIndex* pblockindex = chainman.m_blockman.LookupBlockIndex(block_hash);
if (!pblockindex) {
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Block not found");
}
chainman.ActiveChainstate().ResetBlockFailureFlags(pblockindex);
}
BlockValidationState state;
chainman.ActiveChainstate().ActivateBestChain(state);
if (!state.IsValid()) {
throw JSONRPCError(RPC_DATABASE_ERROR, state.ToString());
}
}
static RPCHelpMan reconsiderblock()
{
return RPCHelpMan{"reconsiderblock",
@ -1640,22 +1659,7 @@ static RPCHelpMan reconsiderblock()
ChainstateManager& chainman = EnsureAnyChainman(request.context);
uint256 hash(ParseHashV(request.params[0], "blockhash"));
{
LOCK(cs_main);
CBlockIndex* pblockindex = chainman.m_blockman.LookupBlockIndex(hash);
if (!pblockindex) {
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Block not found");
}
chainman.ActiveChainstate().ResetBlockFailureFlags(pblockindex);
}
BlockValidationState state;
chainman.ActiveChainstate().ActivateBestChain(state);
if (!state.IsValid()) {
throw JSONRPCError(RPC_DATABASE_ERROR, state.ToString());
}
ReconsiderBlock(chainman, hash);
return UniValue::VNULL;
},