Russell Yanofsky
37bdcca3c3
[refactor] Make feebumper namespace
...
Future commit will remove the FeeBumper class. This commit simply places
everything into a feebumper namespace, and changes the enum class name
from BumpeFeeResult to feebumper::Result.
2017-11-10 17:03:15 -05:00
Russell Yanofsky
7c4f009195
[trivial] Rename feebumper variables according to project code style
...
Future PRs will completely refactor this translation unit and touch all
this code so we rename the variables to follow project stlye guidelines
in this preparation commit.
Don't use m_ prefixes for member variables since we're going to remove
the class entirely in the next commits.
2017-11-10 17:01:41 -05:00
Matt Corallo
9e9e31aa10
Fix qt build broken by 5a5e4e9
2017-11-09 10:43:13 -05:00
Pieter Wuille
5c8ff0d448
Introduce wrappers around CBitcoinAddress
...
This patch removes the need for the intermediary Base58 type
CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination
function that directly operate on the conversion between strings
and CTxDestination.
2017-09-06 13:07:45 -07:00
MarcoFalke
a31e9ad4f0
Merge #11247 : qt: Use IsMine to validate custom change address
...
a1ea1cfbd#11137
Closes #11184 (which was accidentally opened against 0.15 branch)
Tree-SHA512: a20a59b4f36c1471a9c84bcc7c69048576d1f413104c299a7ed9ba221f28eddf93d727fca2926420ea5d0dd9aba582924f26a5acd44d995039b7202c73eb53bc
2017-09-05 16:00:37 -07:00
Chris Moore
a1ea1cfbd8
qt: Use IsMine to validate custom change address
...
(cherry picked from commit c41224dfd5
2017-09-05 15:22:28 -07:00
Wladimir J. van der Laan
fc51565cbd
Merge #11039 : Avoid second mapWallet lookup
...
8f2f1e0
2017-08-18 16:25:59 +02:00
João Barbosa
8f2f1e0458
wallet: Avoid second mapWallet lookup
2017-08-14 23:06:06 +01:00
Marko Bencun
bb81e17355
scripted-diff: stop using the gArgs wrappers
...
They were temporary additions to ease the transition.
-BEGIN VERIFY SCRIPT-
find src/ -name "*.cpp" ! -wholename "src/util.h" ! -wholename "src/util.cpp" | xargs perl -i -pe 's/(?<!\.)(ParseParameters|ReadConfigFile|IsArgSet|(Soft|Force)?(Get|Set)(|Bool|)Arg(s)?)\(/gArgs.\1(/g'
-END VERIFY SCRIPT-
2017-08-14 17:02:10 +02:00
Alex Morcos
03ee701161
Refactor to use CoinControl in GetMinimumFee and FeeBumper
...
Improve parameter precedence in coin_control
2017-07-14 23:10:58 -04:00
Alex Morcos
ecd81dfa3c
Make CoinControl a required argument to CreateTransaction
2017-07-14 23:07:18 -04:00
Alex Morcos
f135923ee2
Add RPC options for RBF, confirmation target, and conservative fee estimation.
...
Add support for setting each of these attributes on a per RPC call basis to sendtoaddress, sendmany, fundrawtransaction (already had RBF), and bumpfee (already had RBF and conf target).
2017-07-10 12:40:02 -04:00
Alex Morcos
d507c301bc
Introduce a fee estimate mode.
...
GetMinimumFee now passes the conservative argument into estimateSmartFee.
Call CalculateEstimateType(mode) before calling GetMinimumFee or estimateSmartFee to determine the value of this argument.
CCoinControl can now be used to control this mode.
2017-07-06 22:20:23 -04:00
Wladimir J. van der Laan
6dbcc74a0e
Merge #10193 : scripted-diff: Remove #include <boost/foreach.hpp>
...
b1268a159957353eff82733aed5b300851e
2017-07-04 18:05:18 +02:00
Dimitris Tsapakidis
0a5a6b90bc
Fixed multiple typos
...
A few "a->an" and "an->a".
"Shows, if the supplied default SOCKS5 proxy" -> "Shows if the supplied default SOCKS5 proxy". Change made on 3 occurrences.
"without fully understanding the ramification of a command" -> "without fully understanding the ramifications of a command".
Removed duplicate words such as "the the".
2017-06-22 19:18:10 +03:00
Jorge Timón
5995735c5b
scripted-diff: Remove #include <boost/foreach.hpp>
...
-BEGIN VERIFY SCRIPT-
sed -i ':a;N;$!ba;s/#include <boost\/foreach.hpp>\n//' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp
-END VERIFY SCRIPT-
2017-06-22 03:48:52 +02:00
Jorge Timón
18dc3c3962
scripted-diff: Remove Q_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2017-06-05 20:11:01 +02:00
Jorge Timón
7c00c26726
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2017-06-05 20:10:50 +02:00
Jonas Schnelli
32325a3f58
[Qt] hide bump context menu action if tx already has been bumped
2017-05-24 17:08:19 +02:00
Wladimir J. van der Laan
ce8176d038
Merge #10295 : [qt] Move some WalletModel functions into CWallet
...
108f04f429aa9ed944bd7ef8ca17
2017-05-23 19:32:52 +02:00
practicalswift
e49b868cfe
[qt] Remove excess logic
...
Replace …
```
if (foo) { return true; } else { return false; }
```
… with the equivalent …
```
return foo;
```
2017-05-18 20:48:14 +02:00
Russell Yanofsky
d944bd7a27
[qt] Move some WalletModel functions into CWallet
...
Motivation for moving these is to make supporting IPC simpler (#10102 ), so
these lookups can be one-shot IPC requests, instead of back-and-forth
interactions over the IPC channel.
Also these functions are potentially useful outside of the bitcoin GUI (e.g.
for RPCs).
2017-05-17 05:18:25 -04:00
Jonas Schnelli
6ed4368f12
Make sure we use nTxConfirmTarget during Qt fee bumps
2017-05-11 15:27:05 +02:00
Jonas Schnelli
2678d3dc63
Show old-fee, increase a new-fee in Qt fee bumper confirmation dialog
2017-05-11 15:27:05 +02:00
Jonas Schnelli
fbf385cc83
[Qt] simple fee bumper with user verification
2017-05-11 15:27:04 +02:00
Jorge Timón
1c897fc3da
Missing includes
2017-04-13 02:31:44 +02:00
Jonas Schnelli
9c7b7cf0bb
Merge #9592 : [Qt] Add checkbox in the GUI to opt-in to RBF when creating a transaction
...
c4e4792838a58e568c05a
2017-03-17 15:31:52 +01:00
Russell Yanofsky
af61d9f78b
Add COutput::fSafe member for safe handling of unconfirmed outputs
...
This exposes a value computed in CWallet::AvailableCoins so it can used for
other things, like inclusion in listunspent output.
2017-03-10 05:11:10 +00:00
Russell Yanofsky
c4e4792c53
[Qt] Change RBF checkbox to reflect -walletrbf setting
...
Before this commit, the checkbox would always start off unchecked. After this
commit it will respect the -walletrbf setting (which is currently false by
default).
2017-01-25 12:51:06 -05:00
isle2983
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
2016-12-31 11:01:21 -07:00
Alex Morcos
28f8ae8adf
Fix missed change to WalletTx structure
2016-12-06 08:56:12 -05:00
Pieter Wuille
c3f5673a63
Make CWalletTx store a CTransactionRef instead of inheriting
2016-12-02 18:28:22 -08:00
Matt Corallo
76faa3cdfe
Rename the remaining main.{h,cpp} to validation.{h,cpp}
2016-12-02 09:42:51 -08:00
Matt Corallo
e736772c56
Move network-msg-processing code out of main to its own file
2016-12-02 09:42:51 -08:00
MarcoFalke
3333e5a1e5
[qt] Return useful error message on ATMP failure
2016-10-30 18:23:37 +01:00
Wladimir J. van der Laan
d2143dc937
Merge #8989 : [Qt] overhaul smart-fee slider, adjust default confirmation target
...
cfe77ef6f02899004168d
2016-10-28 14:14:55 +02:00
Jonas Schnelli
6f0289967f
[Qt] Hide nTxConfirmTarget behind WalletModel
2016-10-28 10:44:30 +02:00
instagibbs
169bdabe14
Return useful error message on ATMP failure
2016-10-26 15:59:33 -04:00
Jonas Schnelli
3e942a7060
Merge #8774 : Qt refactors to better abstract wallet access
...
178cd881880aeb
2016-10-19 17:08:17 +02:00
Luke Dashjr
1880aeb033
Qt: Get the private key for signing messages via WalletModel
2016-10-04 20:30:10 +00:00
Pavel Janík
f839350420
Do not shadow in src/qt
2016-09-23 12:42:00 +02:00
MarcoFalke
6666ca6379
[qt] WalletModel: Expose disablewallet
2016-09-21 13:11:15 +02:00
Cory Fields
5b446dd5b1
net: Pass CConnection to wallet rather than using the global
2016-09-08 12:04:35 -04:00
Jonas Schnelli
914154f0cc
[Qt] add HD enabled/disabled icon to the status bar
2016-08-19 09:21:04 +02:00
Patrick Strateman
380498aba4
Move BackupWallet to CWallet::BackupWallet
2016-05-16 17:48:25 -07:00
Wladimir J. van der Laan
46880ed2fd
Merge #7688 : List solvability in listunspent output and improve help
...
c3932b3
2016-04-25 14:46:29 +02:00
Jonas Schnelli
8efed3bc93
[Qt] Support for abandoned/abandoning transactions
2016-04-04 09:25:34 +02:00
Pieter Wuille
c3932b3270
List solvability in listunspent output and improve help
2016-03-14 19:22:11 +01:00
MarcoFalke
fa24439ff3
Bump copyright headers to 2015
2015-12-13 18:08:39 +01:00
MarcoFalke
513686dd43
[qt] Use maxTxFee instead of 10000000
2015-11-05 19:16:29 +01:00
