Russell Yanofsky
3fbbb9a640
refactor: Get rid of more redundant chain methods
...
This just drops three interfaces::Chain methods replacing them with other calls.
Motivation for removing these chain methods:
- Need to get rid of findFirstBlockWithTimeAndHeight for #10102 , which doesn't
support overloaded methods
- Followup from
https://github.com/bitcoin/bitcoin/pull/16426#discussion_r412487403
- phantomcircuit comments about findNextBlock test
http://www.erisian.com.au/bitcoin-core-dev/log-2020-06-06.html#l-214
Behavior is not changing in any way here. A TODO comment in
ScanForWalletTransactions was removed, but just because it was invalid (see
https://github.com/bitcoin/bitcoin/pull/19195#discussion_r448020762 ), not
because it was implemented.
2020-12-07 09:09:53 -04:00
Antoine Poinsot
86ff2cf202
Remove the remaining fee estimation globals
...
This moves the CBlockPolicyEstimator to the NodeContext, which get rids
of two globals and allows us to conditionally create the
CBlockPolicyEstimator (and to remove a circular dep).
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
2020-12-03 12:56:37 +01:00
Antoine Poinsot
03bfeee957
interface: remove unused estimateSmartFee method from node
...
Co-Authored-by: MarcoFalke <falke.marco@gmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
2020-12-03 12:56:36 +01:00
Fabian Jahr
1e62350ca2
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
Russell Yanofsky
2a26771d81
Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp
...
No changes to ChainImpl or any related classes (review with `git diff --color-moved=dimmed_zebra`)
2020-11-24 10:13:23 -05:00
Russell Yanofsky
12bd0fc9d7
Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp
2020-11-24 10:13:23 -05:00
