12 commits

Author	SHA1	Message	Date
TheCharlatan	ba8fc7d788	refactor: Replace string chain name constants with ChainTypes ... This commit effectively moves the definition of these constants out of the chainparamsbase to their own file. Using the ChainType enums provides better type safety compared to passing around strings. The commit is part of an ongoing effort to decouple the libbitcoinkernel library from the ArgsManager and other functionality that should not be part of the kernel library.	2023-05-09 15:49:14 +02:00
TheCharlatan	be55f545d5	move-only: Extract common/args and common/config.cpp from util/system ... This is an extraction of ArgsManager related functions from util/system into their own common file. Config file related functions are moved to common/config.cpp. The background of this commit is an ongoing effort to decouple the libbitcoinkernel library from the ArgsManager. The ArgsManager belongs into the common library, since the kernel library should not depend on it. See doc/design/libraries.md for more information on this rationale.	2023-04-19 10:48:30 +02:00
MarcoFalke	aaaa37abba	fuzz: Fix memory leak in system fuzz target	2021-09-29 13:24:14 +02:00
Russell Yanofsky	93b9800fec	scripted-diff: Rename overloaded int GetArg to GetIntArg ... Improve readability of code, simplify future scripted diff cleanup PRs, and be more consistent with naming for GetBoolArg. This will also be useful for replacing runtime settings type checking with compile time checking. -BEGIN VERIFY SCRIPT- git grep -l GetArg | xargs sed -i 's/GetArg(\([^)]*\( [0-9]\+\|-1\|port\|BaseParams().RPCPort()\|Params().GetDefaultPort()\|_TIMEOUT\|Height\|_WORKQUEUE\|_THREADS\|_CONNECTIONS\|LIMIT\|SigOp\|Bytes\|_VERSION\|_AGE\|_CHECKS\|Checks() ? 1 : 0\|_BANTIME\|Cache\|BLOCKS\|LEVEL\|Weight\|Version\|BUFFER\|TARGET\|WEIGHT\|TXN\|TRANSACTIONS\|ADJUSTMENT\|i64\|Size\|nDefault\|_EXPIRY\|HEIGHT\|SIZE\|SNDHWM\|_TIME_MS\)\))/GetIntArg(\1)/g' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>	2021-09-27 06:57:20 -04:00
MarcoFalke	fa7718344d	fuzz: Avoid OOM in system fuzz target	2021-08-06 12:31:28 +02:00
fanquake	57e980d13c	scripted-diff: remove Optional & nullopt ... -BEGIN VERIFY SCRIPT- git rm src/optional.h sed -i -e 's/Optional</std::optional</g' $(git grep -l 'Optional<' src) sed -i -e 's/{nullopt}/{std::nullopt}/g' $(git grep -l 'nullopt' src) sed -i -e 's/ nullopt;/ std::nullopt;/g' $(git grep -l 'nullopt' src) sed -i -e 's/ nullopt)/ std::nullopt)/g' $(git grep -l 'nullopt' src) sed -i -e 's/(nullopt)/(std::nullopt)/g' $(git grep -l 'nullopt' src) sed -i -e 's/ nullopt,/ std::nullopt,/g' $(git grep -l 'nullopt' src) sed -i -e 's/? nullopt :/? std::nullopt :/g' $(git grep -l 'nullopt' src) sed -i -e 's/: nullopt}/: std::nullopt}/g' $(git grep -l 'nullopt' src) sed -i -e '/optional.h \\/d' src/Makefile.am sed -i -e '/#include <optional.h>/d' src/test/fuzz/autofile.cpp src/test/fuzz/buffered_file.cpp src/test/fuzz/node_eviction.cpp sed -i -e 's/#include <optional.h>/#include <optional>/g' $(git grep -l '#include <optional.h>' src) -END VERIFY SCRIPT-	2021-03-15 10:41:30 +08:00
MarcoFalke	fae216a73d	scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext ... -BEGIN VERIFY SCRIPT- # Rename sed -i -e 's/MakeFuzzingContext/MakeNoLogFileContext/g' $(git grep -l MakeFuzzingContext) # Bump the copyright of touched files in this scripted diff to avoid touching them again later ./contrib/devtools/copyright_header.py update ./src/test/fuzz/ -END VERIFY SCRIPT-	2021-02-22 10:27:22 +01:00
MarcoFalke	fa61b9d1a6	util: Add ArgsManager::GetCommand() and use it in bitcoin-wallet ... Co-Authored-by: Anthony Towns <aj@erisian.com.au>	2021-01-21 19:31:28 +01:00
MarcoFalke	fa75d40ef8	fuzz: Introduce CallOneOf helper to replace switch-case ... Can be reviewed with --ignore-all-space	2021-01-11 10:37:16 +01:00
MarcoFalke	44444ba759	fuzz: Link all targets once	2020-12-10 07:15:42 +01:00
Harris	095bc9a106	fuzz: fix vector size problem in system fuzzer ... Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>	2020-05-08 20:21:48 +02:00
practicalswift	a19598cf98	tests: Add fuzzing harness for functions in system.h (ArgsManager)	2020-04-26 20:23:56 +00:00