MarcoFalke
8bfa13b15b
Merge #9936 : [trivial] Fix three typos introduced into walletdb.h in commit 7184e25
...
fdab3097184e25c80
2017-03-08 14:15:47 +01:00
Wladimir J. van der Laan
30ff3a2fc9
Merge #9602 : Remove coin age priority and free transactions - implementation
...
b421e6d7d4e950359e8a0f9b937149be7e10315888f838005ad727f4fe282ac400b151272b25a12839cdddf58c7
2017-03-07 19:30:23 +01:00
Wladimir J. van der Laan
3178b2c740
Merge #9369 : Factor out CWallet::nTimeSmart computation into a method.
...
630fc541f98abec6b82d1
2017-03-07 17:11:59 +01:00
practicalswift
fdab309670
[trivial] Fix typos introduced in 7184e25c80
2017-03-07 09:16:46 +01:00
Matt Corallo
0235be1e7a
Rename FlushWalletDB -> CompactWalletDB, add function description
2017-03-06 18:35:20 -05:00
Matt Corallo
735d9b5362
Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
2017-03-06 18:35:19 -05:00
Wladimir J. van der Laan
72fb5158b1
Merge #9906 : Disallow copy constructor CReserveKeys
...
188f89c
2017-03-06 18:33:24 +01:00
Gregory Sanders
188f89c3bb
Disallow copy of CReserveKeys
2017-03-06 09:26:10 -05:00
Jonas Schnelli
7184e25c80
[Wallet] refactor CWallet/CWalletDB/CDB
...
Try to hide CDB/bitdb behinde CWalletDB.
Prepare for full wallet database abstraction.
2017-03-06 11:30:24 +01:00
Wladimir J. van der Laan
fa625b078b
Merge #9333 : Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry.
...
87ed396a1fe944654e044
2017-03-06 10:18:19 +01:00
Wladimir J. van der Laan
5a6af31722
Merge #9908 : Define 7200 second timestamp window constant
...
e57a1fd
2017-03-06 10:02:05 +01:00
Wladimir J. van der Laan
56ab672b59
Merge #9576 : [wallet] Remove redundant initialization
...
343ba8f
2017-03-06 09:40:06 +01:00
Alex Morcos
359e8a03d1
[cleanup] Remove coin age priority completely.
...
Remove GetPriority and ComputePriority. Remove internal machinery for tracking priority in CTxMemPoolEntry.
2017-03-03 16:50:20 -05:00
Alex Morcos
f838005444
No longer allow "free" transactions
...
Remove -limitfreerelay and always enforce minRelayTxFee in the mempool (except from disconnected blocks)
Remove -relaypriority, the option was only used for the ability to allow free transactions to be relayed regardless of their priority. Both notions no longer apply.
2017-03-03 16:50:19 -05:00
Russell Yanofsky
e57a1fd899
Define 7200 second timestamp window constant
2017-03-03 13:51:41 -05:00
Russell Yanofsky
630fc549e2
Clean up braces in CWallet::ComputeTimeSmart
2017-03-03 11:22:44 -05:00
Russell Yanofsky
6c996c2df7
Add documentation describing CWallet::nTimeSmart.
...
Most of the text comes from the 2012 Luke Dashjr <luke-jr+git@utopios.org>
c3f95ef
2017-03-03 11:22:44 -05:00
Russell Yanofsky
1f98abe47b
Factor out CWallet::nTimeSmart computation into a method.
...
No change in behavior, this change just pulls some code out of
CWallet::AddToWallet that was making it very long into a separate method.
2017-03-03 11:22:44 -05:00
Russell Yanofsky
c6b82d1db5
Add tests for CWalletTx::nTimeSmart
2017-03-03 11:22:44 -05:00
Wladimir J. van der Laan
67c5cc1917
Merge #9828 : Avoid -Wshadow warnings in wallet_tests
...
09fe346
2017-03-03 16:08:50 +01:00
Wladimir J. van der Laan
75d012e8c7
Merge #8808 : Do not shadow variables (gcc set)
...
ad1ae7a9de90bb
2017-03-03 15:48:53 +01:00
Wladimir J. van der Laan
eb281842b7
Merge #8775 : RPC refactoring: Access wallet using new GetWalletForJSONRPCRequest
...
d6787719756be386be48aa435632ad15734bf8a04a2e518e3d77ad6deca550f
2017-03-03 13:38:42 +01:00
MarcoFalke
f7ec7cfd38
Merge #9359 : Add test for CWalletTx::GetImmatureCredit() returning stale values.
...
7ed143c
2017-03-02 22:30:15 +01:00
Wladimir J. van der Laan
65d90f585a
Merge #9143 : Refactor ZapWalletTxes to avoid layer violations
...
0165a56
2017-03-02 11:32:34 +01:00
Russell Yanofsky
7ed143c10e
Add test for CWalletTx::GetImmatureCredit() returning stale values.
...
Add test for cached immature credit flag not being cleared in
CWalletTx::MarkDirty() bug, which was fixed in
https://github.com/bitcoin/bitcoin/pull/8717 , commit a560378
2017-03-01 05:11:46 -05:00
practicalswift
343ba8fef5
[wallet] Remove redundant initialization
...
Prior to this commit pindexRescan was initialized to a chainActive.Tip().
However, the value of pindexRescan set at time of initialization was never
read before pindexRescan was being set to either chainActive.Genesis()
(case 1), FindForkInGlobalIndex(chainActive, locator) (case 2) or
chainActive.Genesis() (case 3). Thus, the initialization was redundant.
This commit a.) removes the redundant initialization and b.) simplifies
this logic so that pindexRescan is initialized to chainActive.Genesis()
(case 1 and 3), and set to FindForkInGlobalIndex(chainActive, locator)
(case 2) as needed.
2017-02-28 16:54:43 +01:00
Wladimir J. van der Laan
7e2a2212ec
Merge #9829 : Fix importmulti returning rescan errors for wrong keys
...
306bd72
2017-02-28 13:52:50 +01:00
Wladimir J. van der Laan
30bdcfca2b
Merge #9865 : Change bitcoin address in RPC help message
...
83ac719
2017-02-28 11:59:34 +01:00
Luke Dashjr
d678771c66
Wallet: Sanitise -wallet parameter
2017-02-27 20:45:18 +00:00
Luke Dashjr
9756be382e
Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet RPCRunLater job name
...
The job name is logged, and could pose as an information leak to someone attacking the process, helping them counteract ASLR protections
2017-02-27 20:45:18 +00:00
Luke Dashjr
86be48a77c
More tightly couple EnsureWalletIsAvailable with GetWalletForJSONRPCRequest where appropriate
2017-02-27 20:45:18 +00:00
Luke Dashjr
a4356328e0
Move wallet RPC declarations to rpcwallet.h
2017-02-27 20:45:18 +00:00
Luke Dashjr
bf8a04a165
Reformat touched lines with C++11
2017-02-27 20:45:18 +00:00
Luke Dashjr
2e518e313b
Move nWalletUnlockTime to CWallet::nRelockTime, and name timed task unique per CWallet
2017-02-27 20:45:17 +00:00
Luke Dashjr
d77ad6d416
RPC: Do all wallet access through new GetWalletForJSONRPCRequest
2017-02-27 20:45:17 +00:00
Luke Dashjr
eca550f250
RPC/Wallet: Pass CWallet as pointer to helper functions
2017-02-27 20:45:17 +00:00
MarcoFalke
ddf58c7573
wallet: Remove sendfree
...
This removes the option from the wallet to not pay a fee on "small"
transactions which spend "old" inputs.
This code is no longer worth keeping around, as almost all miners
prefer not to include transactions which pay no fee at all.
2017-02-27 11:23:50 -05:00
Russell Yanofsky
306bd72157
Fix importmulti returning rescan errors for wrong keys
...
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
2017-02-27 07:38:51 -05:00
Wladimir J. van der Laan
75a109338f
tests: Fix dangling pwalletMain pointer in wallet tests
2017-02-27 13:15:39 +01:00
Marijn Stollenga
83ac719d34
Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did).
2017-02-26 14:01:05 +01:00
Russell Yanofsky
f81f0d0030
Update sendfrom RPC help to correct coin selection misconception
2017-02-23 13:44:12 -05:00
Russell Yanofsky
09fe346a4f
Avoid -Wshadow warnings in wallet_tests
...
Warnings introduced by commit e2e2f4chttps://github.com/bitcoin/bitcoin/pull/9773 and
https://github.com/bitcoin/bitcoin/pull/9827
wallet/test/wallet_tests.cpp: In member function ‘void wallet_tests::rescan::test_method()’:
wallet/test/wallet_tests.cpp:377:17: warning: declaration of ‘wallet’ shadows a global declaration [-Wshadow]
CWallet wallet;
2017-02-22 14:11:44 -05:00
Wladimir J. van der Laan
ba7220b5e8
Merge #9773 : Return errors from importmulti if complete rescans are not successful
...
e2e2f4c
2017-02-22 12:43:11 +01:00
Wladimir J. van der Laan
5f0556d032
Merge #9727 : Remove fallbacks for boost_filesystem < v3
...
056aba2
2017-02-21 17:08:37 +01:00
Wladimir J. van der Laan
2dad02232a
Merge #9760 : [wallet] Remove importmulti always-true check
...
ec1267f
2017-02-20 17:30:07 +01:00
MarcoFalke
aa5fa642b0
Merge #9696 : [trivial] Fix recently introduced typos in comments
...
0c9b9b7
2017-02-18 12:13:09 +01:00
Russell Yanofsky
e2e2f4c856
Return errors from importmulti if complete rescans are not successful
2017-02-17 14:12:31 -05:00
Russell Yanofsky
ec1267f13b
[wallet] Remove importmulti always-true check
...
Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from
importmulti, which is always true because nLowestTimestamp is set to the
minimum of the most recent block time and all the imported key timestamps,
which is necessarily lower than the maximum block time.
2017-02-17 07:00:41 -05:00
Russell Yanofsky
e662af3583
Use 2 hour grace period for key timestamps in importmulti rescans
...
Gregory Maxwell <greg@xiph.org> pointed out the lack of grace period in
https://github.com/bitcoin/bitcoin/pull/9490#issue-199407998 .
The importwallet RPC which uses key timestamps in a similar way already has a 2
hour grace period.
2017-02-16 09:05:55 -05:00
Wladimir J. van der Laan
e43a58514d
Merge #9771 : Add missing cs_wallet lock that triggers new lock held assertion
...
07afcd6
2017-02-16 10:30:33 +01:00
