6 commits

Author	SHA1	Message	Date
MarcoFalke	dddd40ba82	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes ... -BEGIN VERIFY SCRIPT- perl -0777 -pi -e 's/#if defined\(HAVE_CONFIG_H\)\n#include <config\/bitcoin-config.h>.*\n#endif.*\n/#include <config\/bitcoin-config.h> \/\/ IWYU pragma: keep\n/g' $( git grep -l '#include <config/bitcoin-config.h>' ) -END VERIFY SCRIPT-	2024-05-01 08:33:04 +02:00
fanquake	dd73c22976	Merge bitcoin/bitcoin#28486: test, bench: Initialize and terminate use of Winsock properly ... fd4c6a10f2 test: Setup networking globally (Hennadii Stepanov) Pull request description: On the master branch, when compiling without external signer support, the `bench_bitcoin.exe` does not initialize Winsock DLL that is required, for example, here: 459272d639/src/bench/addrman.cpp (L124) Moreover, Windows docs explicitly [state](https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsacleanup) that `WSAStartup` and `WSACleanup` must be balanced: > There must be a call to `WSACleanup` for each successful call to `WSAStartup`. Only the final `WSACleanup` function call performs the actual cleanup. The preceding calls simply decrement an internal reference count in the WS2_32.DLL. That is not the case for our unit tests because the `SetupNetworking()` call is a part of the `BasicTestingSetup` fixture and is invoked multiple times, while `~CNetCleanup()` is invoked once only, at the end of the test binary execution. This PR fixes Winsock DLL initialization and termination. More docs: - https://learn.microsoft.com/en-us/windows/win32/winsock/initializing-winsock - https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsastartup - https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsacleanup Fix https://github.com/bitcoin/bitcoin/issues/28940. ACKs for top commit: maflcko: lgtm ACK fd4c6a10f2 Tree-SHA512: d360eaf776943f7f7a35ed5a5f9f3228d9e3d18eb824e5997cdc8eadddf466abe9f2da4910ee3bb86bf5411061e758259f7e1ec344f234ef7996f1bf8781dcda	2023-11-29 17:14:34 +00:00
Hennadii Stepanov	fd4c6a10f2	test: Setup networking globally	2023-11-28 19:11:52 +00:00
MarcoFalke	fa1a384706	Move compat.h include from system.h to system.cpp	2023-10-16 14:34:30 +02:00
MarcoFalke	88887531b7	Move compat/assumptions.h include to one place that actually needs it ... Also add the <IWYU pragma: keep> to avoid removing it by accident.	2023-10-04 11:25:23 +02:00
TheCharlatan	7d3b35004b	refactor: Move system from util to common library ... Since the kernel library no longer depends on the system file, move it to the common library instead in accordance to the diagram in doc/design/libraries.md.	2023-05-20 12:08:13 +02:00

Renamed from src/util/system.h (Browse further)