13 commits

Author	SHA1	Message	Date
Hennadii Stepanov	f47dda2c58	scripted-diff: Bump copyright headers ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT- Commits of previous years: * 2020: fa0074e2d8 * 2019: aaaaad6ac9	2021-12-30 19:36:57 +02:00
Russell Yanofsky	ff5f6dea53	scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader ... Name has been confusing since it was introduced, and it was pointed in recent review club as https://bitcoincore.reviews/10102 that it was particularly unclear how interfaces::WalletClient was different from interfaces::Wallet. -BEGIN VERIFY SCRIPT- ren() { git grep -l "$1" src | xargs sed -i "s/$1/$2/g"; } ren WalletClient WalletLoader ren walletClient walletLoader ren wallet_client wallet_loader ren "wallet clients release the wallet" "wallet pointer owners release the wallet" ren "wallet client" "wallet loader" ren "Wallet client" "Wallet loader" -END VERIFY SCRIPT-	2021-12-22 13:44:55 -05:00
MarcoFalke	fa0074e2d8	scripted-diff: Bump copyright headers ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-	2020-12-31 09:45:41 +01:00
Russell Yanofsky	5baa88fd38	test: Remove no longer needed MakeChain calls ... These calls are no longer needed after edc316020e from #19098 which started instantiating BasicTestingSetup.m_node.chain Patch from MarcoFalke <falke.marco@gmail.com> in https://github.com/bitcoin/bitcoin/pull/19425#discussion_r526701954 Co-authored-by: MarcoFalke <falke.marco@gmail.com>	2020-12-07 20:46:03 -05:00
Russell Yanofsky	e4f4350471	refactor: Move wallet methods out of chain.h and node.h ... Add WalletClient interface so node interface is cleaner and don't need wallet-specific methods. The new NodeContext::wallet_client pointer will also be needed to eliminate global wallet variables like ::vpwallets, because createWallet(), loadWallet(), getWallets(), etc methods called by the GUI need a way to get a reference to the list of open wallets if it is no longer a global variable. Also tweaks splash screen registration for load wallet events to be delayed until after wallet client is created.	2020-08-27 14:33:00 -04:00
MarcoFalke	fac6b9b938	test: Avoid overwriting the NodeContext member of the testing setup	2020-06-06 09:50:32 -04:00
MarcoFalke	faec28252c	scripted-diff: test: Move setup_common to test library ... -BEGIN VERIFY SCRIPT- # Move files for f in $(git ls-files src/test/lib/); do git mv $f src/test/util/; done git mv src/test/setup_common.cpp src/test/util/ git mv src/test/setup_common.h src/test/util/ # Replace Windows paths sed -i -e 's|\\setup_common|\\util\\setup_common|g' $(git grep -l '\\setup_common') sed -i -e 's|src\\test\\lib\\|src\\test\\util\\|g' build_msvc/test_bitcoin/test_bitcoin.vcxproj # Everything else sed -i -e 's|/setup_common|/util/setup_common|g' $(git grep -l 'setup_common') sed -i -e 's|test/lib/|test/util/|g' $(git grep -l 'test/lib/') # Fix include guard sed -i -e 's|BITCOIN_TEST_SETUP_COMMON_H|BITCOIN_TEST_UTIL_SETUP_COMMON_H|g' ./src/test/util/setup_common.h sed -i -e 's|BITCOIN_TEST_LIB_|BITCOIN_TEST_UTIL_|g' $(git grep -l 'BITCOIN_TEST_LIB_') -END VERIFY SCRIPT-	2019-11-06 11:56:41 -05:00
Russell Yanofsky	e6f4f895d5	Pass NodeContext, ConnMan, BanMan references more places ... So g_connman and g_banman globals can be removed next commit.	2019-10-28 10:30:51 -04:00
MarcoFalke	aaaa57c2aa	scripted-diff: Bump copyright headers in wallet ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./src/wallet/ -END VERIFY SCRIPT-	2019-05-06 14:05:52 -04:00
MarcoFalke	fa821904bf	scripted-diff: Rename test_bitcoin to test/setup_common ... -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/test_bitcoin\.(h|cpp)/setup_common.\1/g' $(git grep -l test_bitcoin) git mv ./src/test/test_bitcoin.h ./src/test/setup_common.h git mv ./src/test/test_bitcoin.cpp ./src/test/setup_common.cpp sed -i -e 's/BITCOIN_TEST_TEST_BITCOIN_H/BITCOIN_TEST_SETUP_COMMON_H/g' ./src/test/setup_common.h -END VERIFY SCRIPT-	2019-04-11 10:12:36 -04:00
Russell Yanofsky	ea961c3d72	Remove direct node->wallet calls in init.cpp ... Route calls during node initialization and shutdown that would happen between a node process and wallet processes through the serializable `Chain::Client` interface, rather than `WalletInitInterface` which is now simpler and only deals with early initialization and parameter interaction. This commit mostly does not change behavior. The only change is that the "Wallet disabled!" and "No wallet support compiled in!" messages are now logged earlier during startup.	2018-11-06 11:44:40 -04:00
Russell Yanofsky	8db11dd0b1	Pass chain and client variables where needed ... This commit does not change behavior. All it does is pass new function parameters. It is easiest to review this change with: git log -p -n1 -U0 --word-diff-regex=.	2018-11-06 11:44:40 -04:00
Pierre Rochard	ea3009ee94	wallet: Add walletdir arg unit tests	2018-09-12 21:05:53 -04:00