Hennadii Stepanov
a2e122f0fe
qt: Add GUIUtil::AddButtonShortcut
...
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
2021-05-17 14:01:00 -04:00
Pieter Wuille
4d98b401fb
Change all ping times to std::chrono types
2021-03-03 09:48:07 -08:00
Wladimir J. van der Laan
7fca189a2a
Merge #79 : Embed monospaced font
...
67f26319a0
gui: Add monospaced font settings (Hennadii Stepanov)
22e0114d05
qt: Choose monospaced font in C++ code rather in `*.ui` file (Hennadii Stepanov)
623de12d04
qt: Make GUIUtil::fixedPitchFont aware of embedded font (Hennadii Stepanov)
89e421918e
gui: Add Roboto Mono font (Hennadii Stepanov)
Pull request description:
Qt does not guarantee that the actual applied font matches to the requested one.
It was noted (https://github.com/bitcoin/bitcoin/pull/16432#issuecomment-514486077 ):
> the monospace font looks a bit weird no macOS
... because it is _not_ monospaced.
Also some discrepancies I've noted on Windows while testing Qt 5.15 ([#19716 ](https://github.com/bitcoin/bitcoin/pull/19716 )).
Of course, we could check the actual font with `QFontInfo`, and try to choose another font.
But this PR suggests to just embed a monospaced font, and get the GUI look (partially) independent from a platform.
[Roboto Mono](https://fonts.google.com/specimen/Roboto+Mono ) was chosen after discussion with Bitcoin Design community, and due to its [Apache License, Version 2.0](https://fonts.google.com/specimen/Roboto+Mono#license ).
Changes are scoped to the Overview page only.
---
Screenshots on macOS 10.15.6 (images are simulated by code patching):
- master (ca30d34cf9
)
![Screenshot from 2020-09-03 14-10-03](https://user-images.githubusercontent.com/32963518/92107902-30357d80-edef-11ea-8a4f-b4c758eebf66.png )
- this PR (3fdd5b6bd17a679d6e3876682266092159c52d59)
![Screenshot from 2020-09-03 15-41-36](https://user-images.githubusercontent.com/32963518/92116277-4b5aba00-edfc-11ea-8cb9-22fc44460bfb.png )
---
More screenshots added after https://github.com/bitcoin-core/gui/pull/79#issuecomment-782909149 :
- Linux Mint 20.1 + Cinnamon DE
![DeepinScreenshot_select-area_20210221205410](https://user-images.githubusercontent.com/32963518/108635739-b327be80-7489-11eb-8851-ac89f61199ee.png )
- Windows 10 (with depends)
![DeepinScreenshot_select-area_20210221205056](https://user-images.githubusercontent.com/32963518/108635741-b6bb4580-7489-11eb-8b6b-66be5551eb8c.png )
- macOS Big Sur (with depends)
![DeepinScreenshot_select-area_20210221202917](https://user-images.githubusercontent.com/32963518/108635746-bd49bd00-7489-11eb-8cd2-cf4bb2273a6d.png )
ACKs for top commit:
laanwj:
Tested ACK 67f26319a0
Tree-SHA512: a59775570b8ce314669ede50a0b69f53e8a47a41e7eea428835013240f0ce9afcff6e4c258895455b56806417ed877e5b7a9522f1904e95a5f435db8ccf6078c
2021-02-22 13:01:06 +01:00
MarcoFalke
fd725c2d79
Merge bitcoin-core/gui#204 : Drop buggy TableViewLastColumnResizingFixer class
...
3913d1e8c1
qt: Drop buggy TableViewLastColumnResizingFixer class (Hennadii Stepanov)
Pull request description:
In Qt 5 the last column resizing with dragging its left edge works out-of-the-box.
The current `TableViewLastColumnResizingFixer` implementation could put the last column content out of the view port and confuse a user:
![Screenshot from 2021-01-31 18-04-32](https://user-images.githubusercontent.com/32963518/106390022-fd6bd180-63ee-11eb-9216-6e5117f8dc96.png )
Historical context:
- https://github.com/bitcoin/bitcoin/pull/2862
- https://github.com/bitcoin/bitcoin/pull/3626
- https://github.com/bitcoin/bitcoin/pull/3738
- https://github.com/bitcoin/bitcoin/pull/3920
#205 is a nice addition.
ACKs for top commit:
jarolrod:
ACK 3913d1e8c1
, tested on macOS 11.1 Qt 5.15.2
Talkless:
tACK 3913d1e8c1
, tested on Debian Sid. Can confirm that behavior in previous commit does not produce scroll bar, last column gets "hidden". This PR makes clear that there's more to see in the view.
promag:
Tested ACK 3913d1e8c1
on macos.
Tree-SHA512: 12582dfce54bb1db3d9934ae092e305d32e9760cc99b0265322e161fa7f54b7d6fb6cefedf700783f767d5c3a56a8545c8d2f5ade66596c4e67b8a5287063e8a
2021-02-22 08:13:51 +01:00
Hennadii Stepanov
623de12d04
qt: Make GUIUtil::fixedPitchFont aware of embedded font
2021-02-21 21:01:03 +02:00
Jon Atack
6fc72bd6f0
gui: allow ConnectionTypeToQString to prepend direction optionally
2021-02-06 22:21:16 +01:00
Hennadii Stepanov
3913d1e8c1
qt: Drop buggy TableViewLastColumnResizingFixer class
...
In Qt 5 the last column resizing with dragging its left edge works
out-of-the-box.
The current TableViewLastColumnResizingFixer implementation could put
the last column content out of the view port and confuse a user.
2021-01-31 18:09:30 +02:00
Jon Atack
506e6585a5
gui: display plain "Inbound" in peer details
2021-01-30 20:28:37 +01:00
Jonas Schnelli
68692d33c6
Merge bitcoin-core/gui#85 : Remove unused "What's This" button in dialogs on Windows OS
...
ac7ccd67d7
scripted-diff: Remove unused "What's This" button in dialogs on Windows (Hennadii Stepanov)
b6951483ec
qt: Add flags to prevent a "What's This" button on Windows OS (Hennadii Stepanov)
Pull request description:
Fix #74 .
From [Qt docs](https://doc.qt.io/qt-5/qdialog.html#QDialog ):
> The widget flags _f_ are passed on to the `QWidget` constructor. If, for example, you don't want a **What's This** button in the title bar of the dialog, pass `Qt::WindowTitleHint | Qt::WindowSystemMenuHint` in _f_.
Screenshot on Windows 10 (2004):
- master (3ba25e3bdd
)
![Screenshot from 2020-09-07 16-55-42](https://user-images.githubusercontent.com/32963518/92402384-20dc6a00-f138-11ea-9dcb-3e0f6373ff22.png )
- this PR (e322fe7e19ac504272d14b9b4f9b28b13df888ed)
![Screenshot from 2020-09-07 18-31-16](https://user-images.githubusercontent.com/32963518/92402509-5aad7080-f138-11ea-8b63-9bbbf8b9b9e1.png )
ACKs for top commit:
Bosch-0:
tACK ac7ccd67d7
Tested on Windows 10.0.18363 Build 18363.
promag:
Code review ACK ac7ccd67d7
but with some suggestions.
jonasschnelli:
utACK ac7ccd67d7
Tree-SHA512: f6750a17b7203106cb4db5870becba1cef6a505d4edcc710ba131338bd3aae051510627e62c9bcb8345a7f497c614709e11aeb8f6ae3ea85967bbce2a8c69e64
2021-01-28 10:16:55 +01:00
Jon Atack
4f09615733
gui: return inbound {full, block} relay type in peer details
2021-01-10 21:33:10 +01:00
Jon Atack
7e2beab2d2
gui: create GUIUtil::ConnectionTypeToQString utility function
2021-01-08 15:24:31 +01:00
Jon Atack
e0e55060bf
gui: fix broken doxygen formatting in src/qt/guiutil.h
2020-12-27 14:29:26 +01:00
Jon Atack
0d5613f9de
gui: create GUIUtil::NetworkToQString() utility function
2020-12-27 14:29:24 +01:00
Hennadii Stepanov
5659e73493
qt: Add ObjectInvoke template function
...
This is a replacement of the QMetaObject::invokeMethod functor overload
which is available in Qt 5.10+.
Co-authored-by: Russell Yanofsky <russ@yanofsky.org>
2020-11-25 16:12:23 +02:00
Hennadii Stepanov
b6951483ec
qt: Add flags to prevent a "What's This" button on Windows OS
2020-09-07 19:08:15 +03:00
Hennadii Stepanov
c2f4e5ea1d
qt, refactor: Fix 'split is deprecated' warnings
2020-08-26 20:22:42 +03:00
Hennadii Stepanov
fa5749c805
qt, refactor: Fix 'pixmap is deprecated' warnings
2020-08-26 20:17:52 +03:00
Hennadii Stepanov
b02264cb5d
qt, refactor: Fix 'QDateTime is deprecated' warnings
2020-08-26 20:17:45 +03:00
Hennadii Stepanov
bd315eb5e2
qt: Get rid of cursor in out-of-focus labels
...
This change is a temporary fix of QTBUG-59514.
2020-07-03 18:29:24 +03:00
Jonas Schnelli
0d5c18204b
Merge #17956 : gui: Disable unavailable context menu items in transactions tab
...
2b18fd2242
Disable unavailable context menu items in transactions tab (Kristaps Kaupe)
Pull request description:
Fixes #9192 .
ACKs for top commit:
jonatack:
Re-ACK 2b18fd2242
jonasschnelli:
codereview utACK 2b18fd2242
Tree-SHA512: 4ea19c7b5976f1f0b1baecccb3077cf82f078af7257f92162686bcce2188efe49511a5f557853bc5fe0b10616708957d61c006944babbe60b8105e78751e865f
2020-05-29 10:29:14 +02:00
Hennadii Stepanov
1122817c19
qt: Remove QFont warnings with QPA=minimal
2020-05-13 16:02:38 +03:00
Hennadii Stepanov
1551cea2d5
refactor: Use override for non-final overriders
2020-05-08 10:36:58 +03:00
Jonas Schnelli
afa577c323
Merge #15768 : gui: Add close window shortcut
...
f5a3a5b9ab
gui: Add close window shortcut (Miguel Herranz)
Pull request description:
CMD+W is the standard shortcut in macOS to close a window without
exiting the program.
This adds support to use the shortcut in both main and debug windows.
ACKs for top commit:
jonasschnelli:
Tested ACK f5a3a5b9ab
hebasto:
ACK f5a3a5b9ab
, tested on Linux Mint 19.3 by manually opening available dialogs and sub-windows, and applying the `Ctrl+W` shortcut. Also tested with "Minimize on close" option enabled / disabled.
Tree-SHA512: 39851f6680cf97c334d5759c6f8597cb45685359417493ff8b0566672edbd32303fa15ac4260ec8ab5ea1458a600a329153014f25609e1db9cf399aa851ae2f9
2020-05-04 11:53:34 +02:00
Kristaps Kaupe
2b18fd2242
Disable unavailable context menu items in transactions tab
2020-04-16 19:06:58 +03:00
Ben Woosley
7a810b1d7a
refactor: Convert ping wait time from double to int64_t
2020-03-04 13:45:29 -05:00
Ben Woosley
b054c46977
refactor: Convert ping time from double to int64_t
2020-03-04 13:44:25 -05:00
Miguel Herranz
f5a3a5b9ab
gui: Add close window shortcut
...
CMD+W/CTRL+W is the standard shortcut to close a window without
exiting the program.
2020-02-05 07:13:01 +01:00
MarcoFalke
e09c701e01
scripted-diff: Bump copyright of files changed in 2020
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-01-15 02:18:00 +07:00
Wladimir J. van der Laan
07efb3fe2b
Merge #17826 : qt: Log Qt related info
...
a004673c54
qt: Add LogQtInfo() function (Hennadii Stepanov)
Pull request description:
This PR adds some info to `debug.log` I found useful for testing (e.g., on Wayland) and debugging issues like #17153 :
```
$ ./src/qt/bitcoin-qt -printtoconsole | head -n 6
2020-01-04T14:57:40Z [main] Bitcoin Core version v0.19.99.0-0df287f4e (release build)
2020-01-04T14:57:40Z [main] InitParameterInteraction: parameter interaction: -externalip set -> setting -discover=0
2020-01-04T14:57:40Z [main] Qt 5.9.5 (dynamic), plugin=xcb (dynamic)
2020-01-04T14:57:40Z [main] System: Linux Mint 19.3, x86_64-little_endian-lp64
2020-01-04T14:57:40Z [main] Screen: HDMI-1 1600x1200, pixel ratio=1.0
2020-01-04T14:57:40Z [main] Assuming ancestors of block 00000000000000b7ab6ce61eb6d571003fbe5fe892da4c9b740c49a07542462d have valid signatures.
```
ACKs for top commit:
laanwj:
ACK a004673c54
Tree-SHA512: 496bcfd4870a2730eab92b96b3e74989a7904b21369c372b6d4368f4ca2c141e2fdc1348a1fdd18cb68bb144dcea01d3023bb782f9d030e330c187f6a5a1a082
2020-01-08 14:22:45 +01:00
Hennadii Stepanov
a004673c54
qt: Add LogQtInfo() function
2020-01-05 23:40:01 +02:00
MarcoFalke
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
Hennadii Stepanov
1260ecd812
qt: Add TextWidth() wrapper
...
In Qt 5.12 and before the QFontMetrics::width() is used and it is
deprecated since Qt 13.0.
In Qt 5.11 the QFontMetrics::horizontalAdvance() was introduced.
2019-08-23 21:27:50 +03:00
251
fa1c8e2978
Resolve the qt/guiutil <-> qt/optionsmodal CD
...
This pull request attempts to resolve the `qt/guiutil` <-> `qt/optionsmodel`
circular dependency.
The circular dependency is resolved by moving the `Intro::getDefaultDataDirectory`
member function to `GUIUtil::getDefaultDataDirectory`.
2019-04-23 13:26:06 +02:00
Hennadii Stepanov
7c572c488d
Add workaround for QProgressDialog bug on macOS
...
See: QTBUG-65750, QTBUG-70357.
2019-01-15 01:28:00 +02:00
practicalswift
9096276e0b
Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)
...
Qt-only changes.
2019-01-13 03:25:14 -08:00
João Barbosa
5796671e1d
qt: Add GUIUtil::bringToFront
2018-11-05 11:21:50 +00:00
Wladimir J. van der Laan
78dae8cacc
Merge #13780 : 0.17: Pre-branch maintenance
...
3fc20632a3
qt: Set BLOCK_CHAIN_SIZE = 220 (DrahtBot)
2b6a2f4a28
Regenerate manpages (DrahtBot)
eb7daf4d60
Update copyright headers to 2018 (DrahtBot)
Pull request description:
Some trivial maintenance to avoid having to do it again after the 0.17 branch off.
(The scripts to do this are in `./contrib/`)
Tree-SHA512: 16b2af45e0351b1c691c5311d48025dc6828079e98c2aa2e600dc5910ee8aa01858ca6c356538150dc46fe14c8819ed8ec8e4ec9a0f682b9950dd41bc50518fa
2018-08-08 13:55:27 +02:00
João Barbosa
f7a553177d
gui: Add GUIUtil::ItemDelegate with keyEscapePressed signal
2018-07-30 23:13:04 +01:00
DrahtBot
eb7daf4d60
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
MarcoFalke
a140953907
Merge #13753 : scripted-diff: Remove trailing whitespaces
...
12dd101345
scripted-diff: Remove trailing whitespaces (João Barbosa)
Pull request description:
The script test/lint/lint-whitespace.sh should prevent new cases.
This happens in some pulls where the code editor and the author 'git add's them, so this would fix it all.
Tree-SHA512: bcdd3472fcd01a2754e52212c7db1de2fdc422728b06785481954a27162fb72001cb73708329cc56e95bcc5e45c1348ebc4eacc2ccfa6aa12413c7ec450b6a33
2018-07-25 07:09:33 -04:00
fanquake
fa6e841e89
gui: remove macOS ProgressBar workaround
2018-07-25 07:30:28 +08:00
fanquake
68c272527f
gui: remove SubstituteFonts
2018-07-25 07:30:28 +08:00
João Barbosa
12dd101345
scripted-diff: Remove trailing whitespaces
...
-BEGIN VERIFY SCRIPT-
sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue')
-END VERIFY SCRIPT-
2018-07-24 20:46:23 +01:00
Wladimir J. van der Laan
907f73bbc5
gui: Remove QT_VERSION fallbacks for Qt < 5
...
There were surprisingly many `#ifdef` fallbacks for Qt 4.
Remiving them simplifies maintenance, as well as adding new GUI
functionality.
2018-06-18 12:22:11 +02:00
Russell Yanofsky
17780d6f35
scripted-diff: Avoid interface
keyword to fix windows gitian build
...
Rename `interface` to `interfaces`
Build failure reported by Chun Kuan Lee <ken2812221@gmail.com>
https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756
-BEGIN VERIFY SCRIPT-
git mv src/interface src/interfaces
ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; }
ren interface/ interfaces/
ren interface:: interfaces::
ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_
ren "namespace interface" "namespace interfaces"
-END VERIFY SCRIPT-
2018-04-07 03:42:02 -04:00
Russell Yanofsky
e872c93ee8
Remove direct bitcoin access from qt/guiutil.cpp
2018-04-04 16:52:40 -04:00
practicalswift
3a0f8d795a
Qt: Remove unused method setupAmountWidget(...)
2018-03-25 21:15:08 +02:00
Dimitris Apostolou
4d9b4256d8
Fix typos
2018-03-21 08:34:44 +02:00
Jonas Schnelli
59f9e2aaf3
Use flexible font size for QRCode image address
2018-01-15 09:33:46 -10:00
Akira Takizawa
595a7bab23
Increment MIT Licence copyright header year on files modified in 2017
2018-01-03 02:26:56 +09:00