fanquake
d254f942a5
Merge bitcoin/bitcoin#27324: net: #27257 follow-ups
...
cd0c8eeb09860402ef2eb5a85b365a#27257
* Deletes the copy constructor/assignment operator of `CNetMessage`
* Removes trivial getter for the connection type
* Avoids passing `nRecvFloodSize` to CNode methods by passing it to `CNode` on creation
ACKs for top commit:
jnewbery:
utACK cd0c8eeb09cd0c8eeb09
2023-03-28 11:48:02 +01:00
dergoegge
cd0c8eeb09
[net] Pass nRecvFloodSize to CNode
2023-03-27 16:00:02 +02:00
fanquake
3963067555
Merge bitcoin/bitcoin#26642 : clang-tidy: Add more performance-* checks and related fixes
...
03ec5b6f9c24004372307e975e6cf8516b75f66e03ec5b6f9c03ec5b603ec5b6f9c
2023-03-27 14:34:52 +01:00
Hennadii Stepanov
7e975e6cf8
clang-tidy: Add performance-inefficient-vector-operation check
...
https://clang.llvm.org/extra/clang-tidy/checks/performance/inefficient-vector-operation.html
2023-03-26 20:17:55 +01:00
dergoegge
cc5cdf8776
[net] Deduplicate marking received message for processing
2023-03-19 14:34:37 +01:00
Vasil Dimov
dfc01ccd73
net: simplify the call to vProcessMsg.splice()
...
At the time when
```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), it);
```
is called, `it` is certainly `pnode->vRecvMsg.end()` which makes the
call equivalent to:
```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), pnode->vRecvMsg.end());
```
which is equivalent to:
```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg);
```
Thus, use the latter. Further, maybe irrelevant, but the latter has
constant complexity while the original code is `O(length of vRecvMsg)`.
2023-01-30 11:21:21 +01:00
Hennadii Stepanov
306ccd4927
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
- 2021: f47dda2c58fa0074e2d8aaaaad6ac9
2022-12-24 23:49:50 +00:00
Anthony Towns
bf12abe454
net: drop cs_sendProcessing
...
SendMessages() is now protected g_msgproc_mutex; so this additional
per-node mutex is redundant.
2022-09-15 14:44:42 +10:00
Anthony Towns
d394156b99
net: make CNode::m_permissionFlags const
2022-09-01 20:53:57 +10:00
John Newbery
8d8eeb422e
[net processing] Remove CNode::nLocalServices
2022-07-14 15:25:15 +02:00
John Newbery
d9079fe18d
[net processing] Remove CNode::nServices
...
Use Peer::m_their_services instead
2022-07-14 14:50:44 +02:00
John Newbery
1f52c47d5c
[net processing] Add m_our_services and m_their_services to Peer
...
Track services offered by us and the peer in the Peer object.
2022-07-14 14:44:44 +02:00
MacroFake
fa4be8e7c3
move-only: InitializeNode to handshake helper
2022-07-12 08:41:34 +02:00
MacroFake
fa7098947c
move-only: Version handshake to libtest_util
2022-07-12 08:41:24 +02:00
dergoegge
0101d2bc3c
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
dergoegge
a3c2707039
[net] Add connection type to NodeEvictionCandidate
2022-07-04 14:58:43 +02:00
dergoegge
42aa5d5b62
[net] Add NoBan status to NodeEvictionCandidate
2022-07-04 14:57:49 +02:00
John Newbery
1066d10f71
scripted-diff: rename TxRelay members
...
-BEGIN VERIFY SCRIPT-
ren() { sed -i "s:\<$1\>:$2:g" $(git grep -l "\<$1\>" ./src ./test); }
ren cs_filter m_bloom_filter_mutex
ren fRelayTxes m_relay_txs
ren pfilter m_bloom_filter
ren cs_tx_inventory m_tx_inventory_mutex
ren filterInventoryKnown m_tx_inventory_known_filter
ren setInventoryTxToSend m_tx_inventory_to_send
ren fSendMempool m_send_mempool
ren nNextInvSend m_next_inv_send_time
ren minFeeFilter m_fee_filter_received
ren lastSentFeeFilter m_fee_filter_sent
-END VERIFY SCRIPT-
2022-03-18 11:35:58 +00:00
Hennadii Stepanov
f47dda2c58
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
* 2020: fa0074e2d8aaaaad6ac9
2021-12-30 19:36:57 +02:00
MarcoFalke
fad943821e
scripted-diff: Rename touched member variables
...
-BEGIN VERIFY SCRIPT-
ren() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./src/ ) ; }
ren nLastBlockTime m_last_block_time
ren nLastTXTime m_last_tx_time
ren nTimeConnected m_connected
-END VERIFY SCRIPT-
2021-12-13 13:32:08 +01:00
MarcoFalke
fad7ead146
refactor: Use type-safe std::chrono in net
2021-12-13 12:32:09 +01:00
MarcoFalke
fa00447442
scripted-diff: Use clang-tidy syntax for C++ named arguments
...
-BEGIN VERIFY SCRIPT-
perl -0777 -pi -e 's:((\(|\{|,)(\n| )*)\/\* ?([^=* ]+) ?\*\/ ?:\1/*\4=*/:g' $( git ls-files ./src/test ./src/wallet/test )
-END VERIFY SCRIPT-
2021-11-19 12:41:47 +01:00
Jon Atack
566357f8f7
refactor: move GetRandomNodeEvictionCandidates() to test utilities
...
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
2021-07-06 17:28:15 +02:00
MarcoFalke
fabecce719
net: Treat raw message bytes as uint8_t
2020-11-20 15:11:21 +01:00
MarcoFalke
fa5ed3b4ca
net: Use Span in ReceiveMsgBytes
2020-10-02 16:26:33 +02:00
MarcoFalke
fa6a008434
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
