foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-11 11:16:09 -05:00
Code Issues Activity
36145 commits 6 branches 321 tags 2.5 GiB
Commit graph

59 commits

Author SHA1 Message Date
Andrew Chow
d8e9ca66d1 walletdb: Move Rewrite into BerkeleyDatabase 
Make Rewrite actually a member of BerkeleyDatabase instead of a static
function in BerkeleyBatch
 2020-07-01 12:32:11 -04:00
Andrew Chow
91d109156d walletdb: Move PeriodicFlush into WalletDatabase 
Make PeriodicFlush a non-static member of WalletDatabase instead of
WalletBatch.
 2020-07-01 12:32:06 -04:00
Andrew Chow
8f1bcf8b7b walletdb: Combine VerifyDatabaseFile and VerifyEnvironment 
Combine these two functions into a single Verify function that is a
member of WalletDatabase. Additionally, these are no longer static.
 2020-07-01 12:32:03 -04:00
Wladimir J. van der Laan
26291745ae
Merge #19308: wallet: BerkeleyBatch Handle cursor internally 
ca24edfbc1 walletdb: Handle cursor internally (Andrew Chow)

Pull request description:

  Instead of returning a Dbc (BDB cursor object) and having the caller deal with the cursor, make BerkeleyBatch handle the cursor internally.

  Split from #18971

ACKs for top commit:
  ryanofsky:
    Code review ACK ca24edfbc1. Changes since last review: StartCursor rename, moving CloseCursor calls near returns
  promag:
    Code review ACK ca24edfbc1.

Tree-SHA512: f029b498c7f275aedca53ce7ade7cb99c82975fd6cad17346a4990fb3bcc54e2a5309b32053bd13def9ee464d331b036ac79abb8fc4fa561170c6cfc85283447
 2020-07-01 16:00:32 +02:00
Andrew Chow
ca24edfbc1 walletdb: Handle cursor internally 
Instead of returning a Dbc (BDB cursor object) and having the caller
deal with the cursor, make BerkeleyBatch handle the cursor internally.

This prepares BerkeleyBatch to work with other database systems as Dbc
objects are BDB specific.
 2020-06-22 15:36:23 -04:00
MarcoFalke
fa8a341b88
wallet: Replace CDataStream& with CDataStream&& where appropriate 
The keys and values are only to be used once because their memory is set
to zero. Make that explicit by moving the bytes into the lower level
methods.
 2020-06-20 08:42:35 -04:00
MarcoFalke
fa021e9a5b
wallet: Remove confusing double return value ret+success 
Also, remove redundant comments
 2020-06-20 08:41:19 -04:00
Andrew Chow
a389ed52e8 walletdb: refactor Read, Write, Erase, and Exists into non-template func 
In order to override these later, the specific details of how the Read,
Write, Erase, and Exists functions interact with the actual database
file need to go into functions that are not templated.
 2020-06-17 10:29:27 -04:00
Andrew Chow
61c16339da walletdb: Move BDB specific things into bdb.{cpp/h} 
Leave wallet/db.{cpp/h} for generic WalletDatabase stuff. The BDB
specific stuff goes into bdb.{cpp/h}
 2020-06-15 20:41:05 -04:00