mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-14 11:26:09 -05:00
bf26e018de
The fees for transaction overhead and recipient outputs are now included in nTargetValue instead of being a separate parameter. For the coin selection algorithms, it doesn't matter that these are separate as in either case, the algorithm needs to select enough to cover these fees. Note that setting nValueToSelect is changed as it now includes not_input_fees. Without the change to how nValueToSelect is increased for KnapsackSolver, this would result in overpaying fees. The change to increase by the difference between nFeeRet and not_input_fees allows this to have the same behavior as previously. Additionally, because we assume that KnapsackSolver will always find a solution that requires change (we assume that BnB always finds a non-change solution), we also include the fee for the change output in KnapsackSolver's target. As part of this, we also use the changeless nFeeRet when iterating for KnapsackSolver. This is because we include the change fee when doing KnapsackSolver, so nFeeRet on further iterations won't include the change fee. |
||
|---|---|---|
| .. | ||
| coinselector_tests.cpp | ||
| db_tests.cpp | ||
| init_test_fixture.cpp | ||
| init_test_fixture.h | ||
| init_tests.cpp | ||
| ismine_tests.cpp | ||
| psbt_wallet_tests.cpp | ||
| scriptpubkeyman_tests.cpp | ||
| wallet_crypto_tests.cpp | ||
| wallet_test_fixture.cpp | ||
| wallet_test_fixture.h | ||
| wallet_tests.cpp | ||
| walletdb_tests.cpp | ||