mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-04 10:07:27 -05:00

History

MarcoFalke 03b1db6114 Merge #18766 : Disable fee estimation in blocksonly mode (by removing the fee estimates global) `4e28753f60` feestimator: encapsulate estimation file logic (Antoine Poinsot) `e8ea6ad9c1` init: don't create a CBlockPolicyEstimator if we don't relay transactions (Antoine Poinsot) `86ff2cf202` Remove the remaining fee estimation globals (Antoine Poinsot) `03bfeee957` interface: remove unused estimateSmartFee method from node (Antoine Poinsot) Pull request description: If the `blocksonly` mode is turned on after running with transaction relay enabled for a while, the fee estimation will serve outdated data to both the internal wallet and to external applications that might be feerate-sensitive and make use of `estimatesmartfee` (for example a Lightning Network node). This has already caused issues (for example https://github.com/bitcoin/bitcoin/issues/16840 (C-lightning), or https://github.com/lightningnetwork/lnd/issues/2562 (LND)) and it seems prudent to fail rather than to give inaccurate values. This fixes #16840, and closes #16890 which tried to fix the symptoms (RPC) but not the cause as mentioned by sdaftuar : > If this is a substantial problem, then I would think we should take action to protect our own wallet users as well (rather than hide the results of what our fee estimation would do!). ACKs for top commit: MarcoFalke: re-ACK `4e28753f60` 👋 jnewbery: utACK `4e28753f60` Tree-SHA512: c869cf03b86d8194002970bbc84662dae76874967949b9be0d9a4511a1eabcb1627c38aca3154da9dcece1a4c49ec02bd4f9fcca2ec310986e07904559e63ba8		2020-12-07 12:59:48 +01:00
..
coin.cpp	node: Use mempool from node context instead of global	2019-12-05 14:22:05 -05:00
coin.h	node: Use mempool from node context instead of global	2019-12-05 14:22:05 -05:00
coinstats.cpp	Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const	2020-12-06 00:22:40 +00:00
coinstats.h	rpc: Add hash_type NONE to gettxoutsetinfo	2020-06-22 01:55:36 +02:00
context.cpp	Remove the remaining fee estimation globals	2020-12-03 12:56:37 +01:00
context.h	Remove the remaining fee estimation globals	2020-12-03 12:56:37 +01:00
interfaces.cpp	Remove the remaining fee estimation globals	2020-12-03 12:56:37 +01:00
psbt.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
psbt.h	Have a PSBTAnalysis state that indicates invalid PSBT	2019-11-19 14:54:08 -05:00
README.md	[docs] Document src subdirectories and different libraries	2019-04-09 17:53:08 -04:00
transaction.cpp	style and nits for fee-checking in BroadcastTransaction	2020-10-08 14:11:16 -07:00
transaction.h	scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD	2020-11-26 09:05:59 +00:00
ui_interface.cpp	gui: change combiner for signals to optional_last_value	2020-07-01 21:40:51 +08:00
ui_interface.h	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
utxo_snapshot.h	Convert everything except wallet/qt to new serialization	2020-03-30 16:10:30 -07:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.